MOVEONLY: Policy: Move some policy code #6335

pull jtimon wants to merge 2 commits into bitcoin:master from jtimon:policy-moveonly-0.11.99 changing 16 files +250 −214
  1. jtimon commented at 5:16 pm on June 24, 2015: contributor
    Move policy code out of main (and policy/standard). Nobody seemed to disagree with this part in any of the multiple versions of #6068 and related PRs. This is trivially non-risky, but this PR will be closed when a bitcoin/0.12 branch is created (unless it has been merged first).
  2. jtimon force-pushed on Jun 24, 2015
  3. jonasschnelli commented at 6:24 pm on June 24, 2015: contributor
    Code Review ACK.
  4. petertodd commented at 7:24 pm on June 24, 2015: contributor
    utACK (mostly concept ACK, w/ some code review)
  5. paveljanik commented at 2:48 pm on June 25, 2015: contributor
    utACK
  6. theuni commented at 9:53 pm on June 25, 2015: member
    Confirmed move-only other than the std namespace changes. utACK other than the nit above.
  7. jtimon commented at 7:06 am on June 26, 2015: contributor
    @theuni re additional declaration. It was to not leave the comment alone until it is replaced with the CStandardPolicy method that will replace it in https://github.com/jtimon/bitcoin/commit/3fdcfedadafebb11f5ee01f10ef2c0f0f98c74d5#diff-d22bc3e058f8982972e2eb381a1df668L35 but I’m happy to remove that line if it doesn’t make sense to anyone else. For me having the comment ready there is enough.
  8. btcdrak commented at 12:53 pm on June 26, 2015: contributor
    utACK, needs rebase
  9. morcos commented at 3:39 pm on June 26, 2015: member
    ACK (before the merge conflict)
  10. Policy: MOVEONLY: Create policy/policy.h with some constants 627b9deff4
  11. Policy: MOVEONLY: 3 functions to policy.o:
    - [script/standard.o] IsStandard
    - [main.o] IsStandardTx
    - [main.o] AreInputsStandard
    
    Also, don't use namespace std in policy.cpp
    9238ecb417
  12. jtimon force-pushed on Jun 26, 2015
  13. jtimon commented at 4:03 pm on June 26, 2015: contributor
    Rebased
  14. luke-jr commented at 6:44 pm on June 27, 2015: member
    Concept ACK (did not confirm MOVEONLY since there are other ACKs here).
  15. jtimon commented at 12:18 pm on June 30, 2015: contributor
    @laanwj @sipa ping
  16. laanwj added the label Refactoring on Jul 2, 2015
  17. laanwj merged this on Jul 6, 2015
  18. laanwj closed this on Jul 6, 2015

  19. laanwj referenced this in commit 9546a977d3 on Jul 6, 2015
  20. zkbot referenced this in commit 63c3d1ec94 on Dec 17, 2019
  21. furszy referenced this in commit a5265a4db4 on Jun 27, 2020
  22. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-08 19:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me