add unit tests for the decodescript rpc #6350

pull mruddy wants to merge 1 commits into bitcoin:master from mruddy:raw-decode-unit-tests changing 3 files +121 −0

mruddy commented at 2:10 PM on June 28, 2015: contributor
Adding unit tests for the "decodescript" RPC because:
1. I didn't see any tests specifically for the "decodescript" RPC.
2. In adding these, I added a case that will fail until fixed if/when the OP_NOP2 name decode changes to OP_CHECKLOCKTIMEVERIFY are made. Basically a minor follow-up to #6124 (comment).
3. These will be good to have if/when I get back around to #5264 and #5392.
jgarzik commented at 2:55 PM on June 28, 2015: contributor

ut ACK
laanwj added the label Tests on Jun 29, 2015
laanwj commented at 3:35 PM on June 29, 2015: member

Concept ACK. Thanks for adding tests.

However, wouldn't these be more appropriate in src/qa/rpc-tests/rawtransactions.py?

I suppose it doesn't make much of a difference as this is a stateless utility function.
mruddy commented at 10:46 PM on June 29, 2015: contributor

@laanwj Thanks for the feedback. Yes, I suppose it would make sense to move these over into the python tests. They are more integration level tests anyways. I just did them this way because I had some other changes and could run everything with a single "make check". I'll look at moving these over later today or tomorrow.
add tests for the decodescript rpc. add mention of the rpc regression tests to the testing seciton of the main readme. 70ae43e9b7
mruddy force-pushed on Jun 30, 2015
mruddy commented at 2:01 PM on June 30, 2015: contributor

@laanwj Updated -- I decided to use a separate new decodescript.py file to avoid muddling the existing rawtransactions.py. I also added a short snippet to the main README referencing this set of RPC tests.
laanwj commented at 11:48 AM on July 2, 2015: member

ACK
laanwj merged this on Jul 2, 2015
laanwj closed this on Jul 2, 2015
laanwj referenced this in commit 60abba12ff on Jul 2, 2015
mruddy deleted the branch on Jul 2, 2015
zkbot referenced this in commit 9af55822fb on Feb 15, 2017
zkbot referenced this in commit a7cf698873 on Mar 4, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5264 show scriptSig signature hash types in transaction decodes. fixes #3166 #5392 Remove the "OP_" prefix from transaction script decodes.#6124 Mempool only CHECKLOCKTIMEVERIFY (BIP65) verification, unparameterized version