[Qt] constify foreach uses where possible #6378

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:foreach_const changing 4 files +9 −14

Diapolo commented at 6:15 AM on July 6, 2015: none
- this doesn't replace BOOST_FOREACH, it just makes used arguments const where possible
Diapolo renamed this:
~~[Qt] consity foreach uses where possible~~
[Qt] constify foreach uses where possible
on Jul 6, 2015

in src/qt/coincontroldialog.cpp:None in 692b77c2cf outdated

 689 | @@ -691,8 +690,7 @@ void CoinControlDialog::updateView()
 690 |      map<QString, vector<COutput> > mapCoins;
 691 |      model->listCoins(mapCoins);
 692 |  
 693 | -    BOOST_FOREACH(PAIRTYPE(QString, vector<COutput>) coins, mapCoins)
 694 | -    {
 695 | +    BOOST_FOREACH(const PAIRTYPE(QString, vector<COutput>) coins, mapCoins) {

laanwj commented at 8:26 PM on July 6, 2015:

Do make it a reference as well:

 BOOST_FOREACH(const PAIRTYPE(QString, vector<COutput>) &coins, mapCoins) {

If a copy is made anyway, making it const has little benefit.

laanwj commented at 8:27 PM on July 6, 2015: member

utACK apart from nit

[Qt] constify foreach uses where possible

- this doesn't replace BOOST_FOREACH, it just makes used arguments const
  where possible

5e058e7417

Diapolo commented at 4:55 AM on July 7, 2015: none

@laanwj Thanks for catching that, nit fixed.
laanwj merged this on Jul 9, 2015
laanwj closed this on Jul 9, 2015
laanwj referenced this in commit aa565327ec on Jul 9, 2015
Diapolo deleted the branch on Jul 9, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Diapolo

laanwj