Reformat help text of estimatefee and estimatepriority to match other help texts #6400

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:estimatefee_reformat_help changing 1 files +10 −12

paveljanik commented at 7:53 PM on July 8, 2015: contributor
Longer lines, types aligned.

-1.0 is already documented (see #6395), but the actual returned value is -1.00000000:
```
src$ ./bitcoin-cli estimatepriority 1
-1.00000000
src$ 
```
What about returning signed int -1 instead of float?
laanwj commented at 8:51 AM on July 9, 2015: member

What about returning signed int -1 instead of float?

According to the JSON standard, all numbers are created equal. So distinguishing between 'int' and 'float' on the client side is not robust.

What I would suggest in clients to check for this error condition is <0. Negative value signifies an error, they should not check for an exact value.
paveljanik commented at 9:22 AM on July 9, 2015: contributor

So I will probably change "-1.0 is returned if not enough transactions" to "Negative value is returned if ...". I do not like the difference between -1.0 and -1.000000. It calls for bugs in other applications.
laanwj added the label Docs and Output on Jul 17, 2015
Reformat help text of estimatefee and estimatepriority to match other help texts. 1327897aee

in src/rpcmining.cpp:None in 9a66a44ccc outdated

 708 | -            "n :    (numeric) estimated priority\n"
 709 | +            "n              (numeric) estimated priority\n"
 710 |              "\n"
 711 | -            "-1.0 is returned if not enough transactions and\n"
 712 | -            "blocks have been observed to make an estimate.\n"
 713 | +            "Negative value is returned if not enough transactions and blocks\n"

laanwj commented at 5:08 PM on July 20, 2015:

"A negative value is returned" ?

paveljanik force-pushed on Jul 20, 2015
paveljanik commented at 5:34 PM on July 20, 2015: contributor

Fixed. Squashed.
laanwj merged this on Jul 21, 2015
laanwj closed this on Jul 21, 2015
laanwj referenced this in commit 24f6928192 on Jul 21, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

paveljanik

laanwj

Labels

Docs

Linked (view graph)

#6395 Insane negative estimatefee values.