Closes issue #4997 and restores consistency with the "To Build" instructions in doc/build-unix.md file packaged with the source tarball.
Add autogen.sh to source tarball. #6418
pull randy-waterhouse wants to merge 1 commits into bitcoin:master from randy-waterhouse:master changing 1 files +2 −0-
randy-waterhouse commented at 4:01 AM on July 11, 2015: contributor
-
Add autogen.sh to source tarball. 60d5432697
-
jgarzik commented at 4:10 AM on July 11, 2015: contributor
Concept ACK - though why not use EXTRA_DIST?
-
randy-waterhouse commented at 4:33 AM on July 11, 2015: contributor
We use the noinst because this script is packaged with the src only for building/dev but not to be installed in system directories as are execution/docs/helper script, etc files. tl;dr it gets ignored by the "make install" step but is packaged with src for building/dev.
-
jgarzik commented at 4:36 AM on July 11, 2015: contributor
@randy-waterhouse EXTRA_DIST files are not installed with "make install"
-
randy-waterhouse commented at 5:03 AM on July 11, 2015: contributor
@jgarzik oh yes right,
dist_noinst_SCRIPTSpreserves attributes as they are in the source, and treats it correctly as if it is a source script file with autotool rules that apply to SCRIPTS (that should not be installed) http://www.gnu.org/software/automake/manual/html_node/Scripts.html#Scripts EXTRA_DIST is for files that cannot be handled by regular dist variables and is a generic call that just dists files/directories of all types. As a design philosophy I think executable scripts should be placed clearly up front and treated as an executable script by the build system, with all that implies. -
laanwj commented at 8:00 AM on July 11, 2015: member
utACK
- laanwj added the label Build system on Jul 11, 2015
-
theuni commented at 4:19 PM on July 13, 2015: member
ut ACK
- laanwj merged this on Jul 14, 2015
- laanwj closed this on Jul 14, 2015
- laanwj referenced this in commit d4a910c31e on Jul 14, 2015
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels