Clean up chainparams some more. #6473

1. 
   domob1812 commented at 3:10 pm on July 24, 2015: contributor

   Clean up the code in chainparams a bit more after the recent refactorings. In particular, make sure the structure of the “RegTest” params matches the structure of the other classes. This makes the code clearer to read.

   Also remove redundant values of the genesis block in always-specified optional arguments and mark variable/argument as “const”.

2. 
   sipa commented at 5:22 pm on July 24, 2015: member

   No strong opinion, but looks good to me.
3. 
   jonasschnelli commented at 7:51 am on July 25, 2015: contributor

   ACK (makes sense to remove duplicated parameter default values and the const pass by ref).
4. laanwj added the label Refactoring on Jul 27, 2015
5. 
   laanwj commented at 9:34 am on July 27, 2015: member

   I’d prefer to take this one step further: remove the default arguments from the outer CreateGenesisBlock as well. And specify all the parameters where they belong, together, in the appropriate constructor.
6. domob1812 force-pushed on Jul 28, 2015
7. 
   domob1812 commented at 2:08 pm on July 28, 2015: contributor

   I agree - I’ve updated the patch. When it is finally reviewed and ready, I will squash the commits.
8. 
   laanwj commented at 2:45 pm on July 28, 2015: member

   utACK Looks much better like this.
9. 
   theuni commented at 4:44 pm on July 28, 2015: member

   ut ACK. Agreed that the defaults there are strange.
10. 
    laanwj commented at 4:36 pm on July 29, 2015: member

    @domob1812 can you squash please?
11. domob1812 force-pushed on Jul 29, 2015
12. 
    domob1812 commented at 7:13 pm on July 29, 2015: contributor

    Done.
13. Clean up chainparams some more.

    Clean up the code in chainparams a bit more after the recent
    refactorings.  In particular, make sure the structure of the "RegTest"
    params matches the structure of the other classes.  This makes the code
    clearer to read.
    
    Also remove redundant values of the genesis block in always-specified
    optional arguments and mark variable/argument as "const".

    5fb5c9b213
14. laanwj merged this on Jul 31, 2015
15. laanwj closed this on Jul 31, 2015

    ---

16. laanwj referenced this in commit 86cfd23f68 on Jul 31, 2015
17. domob1812 deleted the branch on Jul 31, 2015
18. zkbot referenced this in commit e1c68f0631 on Jan 19, 2018
19. zkbot referenced this in commit 4f77ce5cb1 on Jan 22, 2018
20. zkbot referenced this in commit cc571a3ccd on Jan 22, 2018
21. zkbot referenced this in commit 50c23880c7 on Jan 22, 2018
22. zkbot referenced this in commit a4a020de7b on Jan 22, 2018
23. MarcoFalke locked this on Sep 8, 2021

Contributors
domob1812 sipa jonasschnelli laanwj theuni

Labels
Refactoring