RPC SendMany Help: remove subtractfeefromamount #6499

pull ChainQuery wants to merge 1 commits into bitcoin:master from ChainQuery:master changing 1 files +0 −8
  1. ChainQuery commented at 5:54 PM on July 31, 2015: none

    Argument 5, subtractfeefromamount, listed in help for sendmany is ignored and not a valid argument.

    Remove it from help.

  2. RPC SendMany Help: remove #5 subtractfeefromamount
    Argument 5, subtractfeefromamount, listed in help for sendmany is ignored and not a valid argument.
    
    Remove it from help.
    20fa1dc546
  3. ChainQuery renamed this:
    RPC SendMany Help: remove #5 subtractfeefromamount
    RPC SendMany Help: remove subtractfeefromamount
    on Jul 31, 2015
  4. casey commented at 6:32 PM on July 31, 2015: contributor

    I'm not sure if I'm reading the code correctly, but it looks like the argument is not ignored. The array is stored in subtractFeeFromAmount on line 969, and then used to create the CRecipient on line 999, which is eventually passed into pwalletMain->CreateTransaction.

  5. ChainQuery commented at 6:46 PM on July 31, 2015: none

    I'm not sure if I'm reading it correctly either, but this was inspired by /contrib/bitrpc/bitrpc.py sendmany inputs starting on line 251. The 5th, subtractfeefromamount, is ignored.

  6. casey commented at 6:57 PM on July 31, 2015: contributor

    It looks like bitrpc.py is just missing the subtractfeefromamount argument. This is an omission in bitrpc.py, not a bug in the help dialog.

  7. ChainQuery commented at 7:02 PM on July 31, 2015: none

    Your right. Closing this request.

  8. ChainQuery closed this on Jul 31, 2015

  9. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me