Get rid of Merkle branches in the wallet #6536

1. 
   sipa commented at 1:25 pm on August 8, 2015: member

   They don’t currently serve any purpose, except as an expensive sanity check.

   However, removing them would result in old clients to no longer treat such transactions as confirmed (until reindexed).

   Is this a compatibility break we’re willing to make for 0.12?

2. 
   sipa commented at 1:26 pm on August 8, 2015: member

   Also see #6508.
3. 
   jonasschnelli commented at 7:33 am on August 11, 2015: contributor

   +1 removing the merkle branches. Maybe fully remove CMerkleTx. Would a auto-rescan at first start after upgrading to a non-CMerkleTx version of bitcoin-cores wallet solve the compatibility issue?
4. 
   dcousens commented at 7:39 am on August 11, 2015: contributor

   concept ACK, could you link to the relevant code that will be removed?
5. 
   sipa commented at 3:47 pm on August 11, 2015: member

   @jonasschnelli Awesome idea! We can just change the name of the block locator, and overwrite the old one with one for the genesis block whenever we upgrade.
6. laanwj added the label Wallet on Sep 22, 2015
7. laanwj closed this on Sep 23, 2015

   ---

8. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa jonasschnelli dcousens

Labels
Wallet