The generate RPC has no default numblocks and a numeric value is required.
Update RPC generate help for numblocks to include required #6609
pull ChainQuery wants to merge 4 commits into bitcoin:master from ChainQuery:master changing 0 files +0 −0-
ChainQuery commented at 7:07 PM on August 31, 2015: none
-
a4f78f00d1
Update rpc generate help to include "required"
The `generate` RPC has no default numblocks and a numeric value is required.
-
380fdb4326
Merge pull request #1 from ChainQuery/ChainQuery-rpc-generate-help-required
Update rpc generate help to include "required"
-
MarcoFalke commented at 11:10 PM on September 1, 2015: member
Can you remove the merge-commit from the branch, please?
-
jonasschnelli commented at 6:51 AM on September 2, 2015: contributor
ACK after squashing (remove merge commit).
-
laanwj commented at 3:22 PM on September 3, 2015: member
Better to be explicit, IMO (defaults are annoying with positional arguments). Apart from that, this call is only used for testing (regtest), adding a default doesn't make much sense.
ACK after removing the spurious commit.
-
7552d1e3df
Revert "Merge pull request #1 from ChainQuery/ChainQuery-rpc-generate-help-required"
This reverts commit 380fdb4326187dfdec9675dcc72e4b0a909c6bd8, reversing changes made to af9305a7e8a40014508fb66a22ae95e8afe142c6.
-
Merge remote-tracking branch 'bitcoin/master' 4dd25fa37a
-
ChainQuery commented at 5:27 PM on September 3, 2015: none
Sorry folks, still figuring out git, going to close this request.
- ChainQuery closed this on Sep 3, 2015
- MarcoFalke locked this on Sep 8, 2021
Contributors