Handle reserved symbols in uacomment (BIP-0014) #6634

issue MarcoFalke opened this issue on September 4, 2015

MarcoFalke commented at 12:19 PM on September 4, 2015: member
Current master happily accepts uacomments (#6462) containing any of the "reserved symbols" mentioned in BIP-0014 and silently drops other characters when pushing to the network. E.g. the hypen-char -:

My local node:
```
getnetworkinfo
[...]
"subversion": "/Satoshi:0.11.99(node-bob_12);:/:)()/",
[...]
```
Some remote node:
```
getpeerinfo
[...]
"subver": "/Satoshi:0.11.99(nodebob_12);:/:)()/",
[...]
```
MarcoFalke commented at 10:55 AM on September 7, 2015: member

PR @ #6647
MarcoFalke closed this on Sep 7, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors