Default fPayAtLeastCustomFee to false #6649

pull RHavar wants to merge 1 commits into bitcoin:master from RHavar:master changing 1 files +1 −1

RHavar commented at 11:24 PM on September 7, 2015: contributor

This allows for much finer control of the transaction fees per kilobyte as it prevent small transactions using a fee that is more appropriate for one that is of a kilobyte.

This also allows controlling the fee per kilobyte over rpc such that:

bitcoin-cli settxfee bitcoin-cli estimatefee 2``

would make sense, while currently it grossly fails often by a factor of x3

This fixes issue #6479, and has minimal impact as dynamic fees are currently the default. This default can be overriden in the qt wallet, although I have trouble imagining where that is useful. Possibly the entire concept of fPayAtLeastCustomFee can be removed in a later version.

Default fPayAtLeastCustomFee to false

This allows for much finer control of the transaction fees per kilobyte
as it prevent small transactions using a fee that is more appropriate
for one that is of a kilobyte.

This also allows controlling the fee per kilobyte over rpc such that:

bitcoin-cli settxfee `bitcoin-cli estimatefee 2`

would make sense, while currently it grossly fails often by a factor of x3

cf4f795216

jonasschnelli commented at 11:53 AM on September 8, 2015: contributor

Looks after a reasonable change. But it would at least require to fix the unit/rpc tests.
laanwj added the label Wallet on Sep 8, 2015
jgarzik commented at 11:32 PM on September 15, 2015: contributor

concept ACK
dcousens commented at 7:19 AM on September 16, 2015: contributor

concept ACK, but this would change the behaviour that a lot of software currently mimics (example)
RHavar commented at 5:13 AM on October 12, 2015: contributor

Closing, as being handled on: PR #6708
RHavar closed this on Oct 12, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6479 Never sends fees with less than paytxfee #6708 [wallet] Default fPayAtLeastCustomFee to false