[qt] [trivial] Delete icons, Cleanup spinner animation #6668

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-spinnerAnimationFix changing 20 files +5 −57

MarcoFalke commented at 2:05 PM on September 13, 2015: member

No description provided.

[qt] [trivial] share/qt/make_spinner.py => src/qt/res/movies/makespinner.sh

* Merge make_spinner.py into makespinner.sh
* Also delete now unused imgs
* Actually use all 36 frames for the spinner animation

d1acf938e6

[trivial] Remove obsolete pixmaps 9b1cdd7eeb

in src/qt/res/movies/makespinner.sh:None in af568032ed outdated

   0 | @@ -1,6 +1,6 @@
   1 | -for i in {1..35}
   2 | +for i in {0..35}
   3 |  do
   4 | -    value=$(printf "%03d" $i)
   5 | +    frame=$(printf "%03d" $i)
   6 |      angle=$(($i * 10))
   7 | -    convert spinner-000.png -background "rgba(0,0,0,0.0)" -distort SRT $angle spinner-$value.png
   8 | +    convert ../src/spinner.png -background "rgba(0,0,0,0.0)" -distort SRT $angle spinner-$frame.png

jonasschnelli commented at 2:08 PM on September 13, 2015:

Maybe use something like FILEDIR=$(dirname $0) instead of ../src. It would allow to run the script from everywhere and still get and place the files in and from the right directory.

MarcoFalke commented at 4:05 PM on September 13, 2015:

Thanks! done.

MarcoFalke force-pushed on Sep 13, 2015
laanwj added the label GUI on Sep 18, 2015
btcdrak commented at 6:21 PM on September 18, 2015: contributor

utACK
laanwj commented at 2:04 PM on September 21, 2015: member

Agree re: cleanup, but you call this 'fix', but there is no description. What is broken about the spinner?
MarcoFalke commented at 2:10 PM on September 21, 2015: member

Nothing broken. The spinner is skipping one frame. Changing SPINNER_FRAMES from 35 to 36 is the "fix".
laanwj commented at 2:12 PM on September 21, 2015: member

ACK
laanwj merged this on Sep 21, 2015
laanwj closed this on Sep 21, 2015
laanwj referenced this in commit 10fc4fb368 on Sep 21, 2015
MarcoFalke deleted the branch on Sep 21, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels