Use a prefix instead of postfix.
This fixes gitian/depends builds to include zmq (linux/osx).
In the Makefile we use $($(host_os)_packages) for (https://github.com/bitcoin/bitcoin/blob/master/depends/Makefile#L81).
depends: fix platform specific packages variable #6684
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2015/09/depends_fix_zmq changing 1 files +2 −2-
jonasschnelli commented at 12:32 PM on September 17, 2015: contributor
-
93254172ce
depends: fix platform specific packages variable
prefix instead of postfix
-
jonasschnelli commented at 1:38 PM on September 17, 2015: contributor
Works for gitian builds: https://bitcoin.jonasschnelli.ch/pulls/6684/build-osx.log https://bitcoin.jonasschnelli.ch/pulls/6684/build-linux.log (search after
checking for ZMQ)Travis issue is unrelated (will address it in another PR).
-
jgarzik commented at 1:40 PM on September 17, 2015: contributor
ACK
- jgarzik merged this on Sep 17, 2015
- jgarzik closed this on Sep 17, 2015
- jgarzik referenced this in commit cb71316a1b on Sep 17, 2015
-
jgarzik commented at 1:47 PM on September 17, 2015: contributor
Merged - in the future, please add text "Fixes #<issue number>" to the git commit message. github will notice that and Do The Right Thing.
-
jonasschnelli commented at 1:50 PM on September 17, 2015: contributor
@jgarzik: right. Did miss that issue. I'd prefer
fixes #in a github commit instead as in a git commit message. Keeps the git repository github clean. -
dcousens commented at 2:38 PM on September 17, 2015: contributor
@jonasschnelli you can have both.
- luke-jr referenced this in commit 9b7c20f318 on Aug 24, 2016
- zkbot referenced this in commit 36df5a92f8 on Feb 9, 2017
- zkbot referenced this in commit dd8b38316f on Feb 9, 2017
- zkbot referenced this in commit 253c610783 on Feb 9, 2017
- DrahtBot locked this on Sep 8, 2021
Contributors