[travis] add zmq python module, re-enable zmq rpc tests #6686

1. 
   jonasschnelli commented at 2:35 pm on September 17, 2015: contributor

   Travis can’t run the zmq tests because its missing the python zmq module. https://travis-ci.org/bitcoin/bitcoin/jobs/80832394#L3588

   This would install the python zmq module and re-enable the rpc tests. Disabling zmq tests on travis would be another solution, but IMO we should maximize the CI test coverage.

   Not sure if this is a good solution (@theuni?).

   Let’s discuss this before merging.

2. jonasschnelli force-pushed on Sep 17, 2015
3. 
   sipa commented at 2:55 pm on September 17, 2015: member

   ACK
4. 
   jgarzik commented at 3:21 pm on September 17, 2015: contributor

   ACK - is both necessary and correct
5. enable zmq-test in rpc-tests.sh 110a1fd727
6. jonasschnelli force-pushed on Sep 17, 2015
7. jonasschnelli force-pushed on Sep 17, 2015
8. jonasschnelli renamed this:
   [travis] add zmq python module
   [travis] add zmq python module and re-enable zmq rpc tests on travis
   on Sep 17, 2015
9. jonasschnelli renamed this:
   [travis] add zmq python module and re-enable zmq rpc tests on travis
   [travis] add zmq python module, re-enable zmq rpc tests
   on Sep 17, 2015
10. jonasschnelli force-pushed on Sep 17, 2015
11. jonasschnelli force-pushed on Sep 17, 2015
12. jonasschnelli force-pushed on Sep 17, 2015
13. jonasschnelli force-pushed on Sep 17, 2015
14. jonasschnelli force-pushed on Sep 17, 2015
15. jonasschnelli force-pushed on Sep 17, 2015
16. jonasschnelli force-pushed on Sep 18, 2015
17. jonasschnelli force-pushed on Sep 18, 2015
18. jonasschnelli force-pushed on Sep 18, 2015
19. jonasschnelli renamed this:
    [travis] add zmq python module, re-enable zmq rpc tests
    [travis] [please don't merge yet / under work] add zmq python module, re-enable zmq rpc tests
    on Sep 18, 2015
20. jonasschnelli force-pushed on Sep 18, 2015
21. jonasschnelli force-pushed on Sep 18, 2015
22. jonasschnelli force-pushed on Sep 18, 2015
23. 
    btcdrak commented at 11:58 pm on September 18, 2015: contributor

    Looks like Travis timed out on a couple of jobs.
24. 
    dcousens commented at 4:23 am on September 19, 2015: contributor

    ACK
25. 
    jonasschnelli commented at 9:15 am on September 19, 2015: contributor

    Somehow even if travis successfully installs libzmq3 and python-zmq, the rpc test can’t connect over zmq with bitcoind. Still try to figure out why…
26. 
    theuni commented at 2:27 am on September 22, 2015: member

    Does this work locally? It’s not clear to me what needs to be native and what needs to be per-arch.
27. 
    jonasschnelli commented at 7:56 am on September 22, 2015: contributor

    @theuni The zmq_test.py (RPC test) works prefect locally. Tested on OSX/Debian and Ubuntu. The zmq_test.py changes within this PR are for debugging purposes. I can only encounter the problem in Travis builds. It looks like that zmq tcp:// connection does not work in travis. Even after installing python-zmq. Also my solution (sudo rm -f /etc/apt/sources.list.d/travis_ci_zeromq3-source.list;) looks after a workaround hack. Maybe you have a different approach to get the zmq_test.py running on travis.
28. laanwj added the label Tests on Sep 23, 2015
29. 
    jonasschnelli commented at 9:13 am on September 29, 2015: contributor

    @theuni: Any idea how we could fix this? Having CI tests for the ZMQ would be important IMO otherwise the risks are high that things break without noticing.
30. 
    theuni commented at 5:39 pm on September 29, 2015: member

    @jonasschnelli I need to spend a bit of time learning about the intricacies of zmq/python here. But I’ll try to track down the issue.
31. 
    theuni commented at 11:48 pm on September 29, 2015: member

    @jonasschnelli This fixes: https://github.com/theuni/bitcoin/commit/05a7243678e97b3944c5ceb23c4b05c57fb9c42f . Problem was the old libzmq that the pyzmq was using. Installing the newer pyzmq from a ppa pulls in newer versions of both.
32. [travis] add zmq python module a9c27cdf55
33. jonasschnelli renamed this:
    [travis] [please don't merge yet / under work] add zmq python module, re-enable zmq rpc tests
    [travis] add zmq python module, re-enable zmq rpc tests
    on Oct 1, 2015
34. jonasschnelli force-pushed on Oct 1, 2015
35. 
    jonasschnelli commented at 1:39 pm on October 1, 2015: contributor

    Added @theuni commit. Travis is happy now. This would add CI coverage of the ZMQ feature.
36. travis: install a recent libzmq and pyzmq for tests 745f909925
37. jonasschnelli force-pushed on Oct 1, 2015
38. 
    laanwj commented at 2:12 pm on October 1, 2015: member

    ACK when travis is green
39. laanwj merged this on Oct 1, 2015
40. laanwj closed this on Oct 1, 2015

    ---

41. laanwj referenced this in commit 17d0e638b6 on Oct 1, 2015
42. luke-jr referenced this in commit 16b2346c9a on Aug 24, 2016
43. luke-jr referenced this in commit 5df5425e72 on Aug 24, 2016
44. zkbot referenced this in commit 36df5a92f8 on Feb 9, 2017
45. zkbot referenced this in commit dd8b38316f on Feb 9, 2017
46. zkbot referenced this in commit 253c610783 on Feb 9, 2017
47. MarcoFalke locked this on Sep 8, 2021

Contributors
jonasschnelli sipa jgarzik btcdrak dcousens theuni laanwj

Labels
Tests