Speed up RPC authentication (reworked pull from Joel Katz) #670

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:rpcauth_speedup changing 1 files +5 −7

gavinandresen commented at 2:11 PM on December 1, 2011: contributor

Caches rpc username and password in static vars, to avoid the overhead of a lookup into mapArgs. Mining pools that handle a lot of getwork calls like this.

Note: I also did a quick benchmark of using a boost::unordered_map for mapArgs instead of a std::map, but unordered_map was slightly slower.
sipa commented at 2:12 PM on December 1, 2011: member

ACK
laanwj commented at 2:34 PM on December 1, 2011: member

Ack
laanwj commented at 3:02 PM on December 1, 2011: member

Btw if speed is really the issue here, an idea would be to cache encoded <user>:<pass> and compare the header literally, this would save a decoding step for each rpc call
gavinandresen commented at 8:47 PM on December 1, 2011: contributor

RE: store strUserPass: good idea!
Speed up RPC authentication (reworked pull from Joel Katz) f81ce5bd6d
gavinandresen referenced this in commit 173efb1865 on Dec 1, 2011
gavinandresen merged this on Dec 1, 2011
gavinandresen closed this on Dec 1, 2011
coblee referenced this in commit 448b602ce1 on Jul 17, 2012
ptschip referenced this in commit 4c0f390285 on Jun 13, 2017
DrahtBot locked this on Sep 8, 2021

Contributors