Backport bugfixes to 0.11 #6703

luke-jr commented at 7:31 AM on September 20, 2015: member

Travis is failing this weirdly, and I'm not sure why. Working on troubleshooting it, but I need to go to bed... so tomorrow I guess.

luke-jr force-pushed on Sep 20, 2015

luke-jr renamed this:
~~Backport bugfixes to 0.11~~
DO NOT MERGE: Backport bugfixes to 0.11
on Sep 20, 2015

jonasschnelli commented at 7:49 AM on September 20, 2015: contributor

Not sure about fd9e6c8509354ba0e88a664127416bc0ae5d647b ("tests: Remove old sh-based test framework"), don't see a urgent need for backporting this. I think - once finalized/merged – we might add #6694 to this PR.

luke-jr force-pushed on Sep 20, 2015

luke-jr commented at 8:03 AM on September 20, 2015: member

I was including fd9e6c8509354ba0e88a664127416bc0ae5d647b because the tests removed are broken and don't work. But I don't feel strongly either way.

luke-jr renamed this:
~~DO NOT MERGE: Backport bugfixes to 0.11~~
Backport bugfixes to 0.11
on Sep 20, 2015

luke-jr force-pushed on Sep 21, 2015

laanwj commented at 11:45 AM on September 21, 2015: member

Concept ACK I thnk this needs bfadae3 to avoid the travis issue

laanwj added the label Bug on Sep 21, 2015

luke-jr force-pushed on Sep 22, 2015

travis: for travis generating an extra build 1f4d7cf20b

Add autogen.sh to source tarball. a37567dd44

tests: Remove old sh-based test framework

This removes the `conflictedbalance.sh` test as well, but that test has
been broken for a long time and isn't part of any scripts.
What it does is, IMO, sufficiently tested by other tests.

49c6a64202

Remove bash test note from rpc-tests readme a496e11d7c

locking: fix a few small issues uncovered by -Wthread-safety

- rpcwallet: No need to lock twice here
- openssl: Clang doesn't understand selective lock/unlock here. Ignore it.
- CNode: Fix a legitimate (though very unlikely) locking bug.

60457d3c2f

Avoid leaking file descriptors in RegisterLoad

This is pretty trivial, but if there's an error here we'll leak a file
descriptor. Changed it to always close the file.

f6355e6918

build: fix libressl detection

Checking libcrypto for a function after we've already found a (possibly
different) libcrypto is not what we want to do here.

pkg-config might've found a cross lib while AC_CHECK_LIB may find a different
or native one.

Run a link-test against the lib that's already been found instead.

5a3913361d

Make sure LogPrintf strings are line-terminated

Fix the cases where LogPrint[f] was accidentally called without line
terminator, which resulted in concatenated log lines.

(see e.g. #6492)

7ff9d122e4

Make sure LogPrint strings are line-terminated e0020d4c44

Delay initial pruning until after wallet init

Don't prune until any wallet rescanning has taken place to avoid
potentially pruning blocks that the wallet rescan may need.

e6adac7b3f

Use unique name for AlertNotify tempfile f6d29a6ca8

Handle no chain tip available in InvalidChainFound()

Handle the case where no chain tip is available, in InvalidChainFound(). This fixes a null pointer deference when running unit tests, if the genesis block or block validation code is broken.

4a3741028e

Fix race condition on test node shutdown c5b89fe44e

Handle leveldb::DestroyDB() errors on wipe failure

Add error checking to CLevelDBWrapper for errors from
leveldb::DestroyDB().  Without it, if unlink() or DeleteFileW() fail to
delete files, they will fail silent.  If they fail to delete any files,
CLevelDBWrapper will silently open and read the existing database.

Typically any permissions issues would be caught by leveldb as it churns
through many files as part of its compaction process, but it is
conceivable that this could cause problems on Windows with anti-virus
and indexing software.

f171fee035

Add missing files to files.md

typo

48770534a6

Make sure we re-acquire lock if a task throws 626c5e6936

Replace boost::reverse_lock with our own. 6b51b9b195

Fix masking of irrelevant bits in address groups. 13642a50eb

add unit test for CNetAddr::GetGroup. 1f6772e9f0

net: Set SO_REUSEADDR for Windows too

When running the rpc tests in Wine, nodes often fail to listen on localhost
due to a stale socket from a previous run. This aligns the behavior with other
platforms.

ccc4ad6c4d

rpc-tests: re-enable rpc-tests for Windows 13bd5a75b5

add support for miniupnpc api version 14

The value of new arg ttl is set to 2 as it's recommended default.

21c406eda0

PARTIAL: typofixes (found by misspell_fixer)

Upstream: 9f68ed6b6d1a9c6436ce37913666165f2b180ee3 (PR #6539)

45bfa137ef

luke-jr force-pushed on Sep 22, 2015

laanwj merged this on Sep 23, 2015

laanwj closed this on Sep 23, 2015

laanwj referenced this in commit 1cd7952dde on Sep 23, 2015

str4d referenced this in commit 7d8e6c7a28 on Sep 22, 2016

str4d referenced this in commit 29f7d67253 on Sep 22, 2016

str4d referenced this in commit 5bce086d88 on Sep 26, 2016

str4d referenced this in commit 51babcb951 on Sep 29, 2016

zkbot referenced this in commit 57d420e2f8 on Feb 15, 2017

zkbot referenced this in commit 88c209dba6 on Feb 20, 2017

zkbot referenced this in commit dadb1ab74c on Mar 3, 2017

MarcoFalke locked this on Sep 8, 2021