Backport bugfixes to 0.10 #6704

pull luke-jr wants to merge 14 commits into bitcoin:0.10 from luke-jr:backport-bugfixes-to-0.10-20150920 changing 21 files +75 −31

luke-jr commented at 7:48 AM on September 20, 2015: member

No description provided.
Add autogen.sh to source tarball. 8b59079b8d

Avoid leaking file descriptors in RegisterLoad

This is pretty trivial, but if there's an error here we'll leak a file
descriptor. Changed it to always close the file.

04507de3b7

build: fix libressl detection

Checking libcrypto for a function after we've already found a (possibly
different) libcrypto is not what we want to do here.

pkg-config might've found a cross lib while AC_CHECK_LIB may find a different
or native one.

Run a link-test against the lib that's already been found instead.

3861f0fa21

Make sure LogPrint strings are line-terminated 4e5ea71bd5
Use unique name for AlertNotify tempfile 843469ee15

Handle leveldb::DestroyDB() errors on wipe failure

Add error checking to CLevelDBWrapper for errors from
leveldb::DestroyDB().  Without it, if unlink() or DeleteFileW() fail to
delete files, they will fail silent.  If they fail to delete any files,
CLevelDBWrapper will silently open and read the existing database.

Typically any permissions issues would be caught by leveldb as it churns
through many files as part of its compaction process, but it is
conceivable that this could cause problems on Windows with anti-virus
and indexing software.

28d76d2aea

Add missing files to files.md
typo
65426acb4d
Fix masking of irrelevant bits in address groups. bdf2542787
add unit test for CNetAddr::GetGroup. 0194bddde4

net: Set SO_REUSEADDR for Windows too

When running the rpc tests in Wine, nodes often fail to listen on localhost
due to a stale socket from a previous run. This aligns the behavior with other
platforms.

c9ad65e5fa

rpc-tests: re-enable rpc-tests for Windows 0dfcdd41eb

add support for miniupnpc api version 14

The value of new arg ttl is set to 2 as it's recommended default.

2ede6b7142

PARTIAL: typofixes (found by misspell_fixer)

Upstream: 9f68ed6b6d1a9c6436ce37913666165f2b180ee3 (PR #6539)

ceba0f8c7e

luke-jr force-pushed on Sep 21, 2015
laanwj commented at 11:43 AM on September 21, 2015: member

Concept ACK
laanwj added the label Bug on Sep 21, 2015
travis: for travis generating an extra build 5e6d893650
luke-jr commented at 4:38 PM on September 21, 2015: member

Ok, Travis workaround backported and passing now.

in contrib/debian/changelog:None in 5e6d893650

 177 | @@ -178,7 +178,7 @@ bitcoin (0.5.0~rc1-natty1) natty; urgency=low
 178 |  
 179 |    * Add test_bitcoin to build test
 180 |    * Fix clean
 181 | -  * Remove uneccessary build-dependancies
 182 | +  * Remove unnecessary build-dependancies

laanwj commented at 3:58 PM on September 22, 2015:

dependancies, huh :-) This is just a backport, but I wonder why the other word spelling wasn't fixed.

laanwj commented at 4:06 PM on September 22, 2015: member

ACK. Going to merge this to make Travis pass again.
laanwj merged this on Sep 22, 2015
laanwj closed this on Sep 22, 2015
laanwj referenced this in commit 743cc9e08b on Sep 22, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

luke-jr

laanwj

Labels

Bug