Trivial: start the help texts with lowercase #6739

1. 
   paveljanik commented at 6:42 am on September 30, 2015: contributor

   All configure --help texts should start with a lowercase letter.
2. [Trivial] start the help texts with lowercase 96106f0f30
3. 
   jonasschnelli commented at 6:55 am on September 30, 2015: contributor

   I think it would make sense to also change from –disable-zmq to –enable-zmq (to fit the current style –enable-wallet etc.)
4. 
   paveljanik commented at 7:00 am on September 30, 2015: contributor

   I had the same feeling when I tested --enable-bench… But: --enable-tests is also enabled by default and the option is described as --enable... so I left it as it is now.

   Looks like I misread what you wrote.

   I personally prefer --disable-feature documented, when it is enabled by default. So I won’t change anything here…

5. 
   jgarzik commented at 12:35 pm on September 30, 2015: contributor

   If it’s enabled by default, the feature logically requires a –disable-foo. And the opposite, for anything disabled by default. (and as seen in #6733 and elsewhere, features should be built, even if runtime-disabled)
6. 
   laanwj commented at 12:59 pm on September 30, 2015: member

   Right - the reasoning would be thus: you never have to pass --enable-zmq, because if the relevant library and version is installed, it picks it up automatically. So documenting --disable-zmq makes sense.

   BTW: if we want to be consistent, we should be consistent, looking at configure output, there are more options that start with uppercase, probably should adapt them as well:

   0  --with-boost-libdir=LIB_DIR
   1                          Force given directory for boost libraries. Note that
   2  --with-libressl         Build with system LibreSSL (default is no;
   3                          DANGEROUS; NOT SUPPORTED)
   

   But re: libressl see also #6732

7. 
   paveljanik commented at 1:09 pm on September 30, 2015: contributor

   Boost one is an upstream issue in http://www.gnu.org/software/autoconf-archive/ax_boost_base.html - I do not want to divert.
8. laanwj added the label Docs and Output on Sep 30, 2015
9. 
   paveljanik commented at 1:24 pm on September 30, 2015: contributor

   Ad enable/disable rewrites:

   0  --enable-shared[=PKGS]  build shared libraries [default=yes]
   1  --enable-static[=PKGS]  build static libraries [default=yes]
   2  --enable-fast-install[=PKGS]
   3                          optimize for fast installation [default=yes]
   4  --enable-wallet         enable wallet (default is yes)
   5  --enable-tests          compile tests (default is yes)
   6  --enable-hardening      attempt to harden the resulting executables (default
   7                          is yes)
   8  --enable-ccache         use ccache for building (default is yes if ccache is
   9                          found)
   

   This is a quick scan of the current configure here.

10. 
    laanwj commented at 4:15 pm on September 30, 2015: member

    OK, fair enough, thanks for checking. Just want to avoid zillions of pulls that change the case of a single character, so if we could have done multiple at once it would be nice. But yes the boost one has to be changed upstream…
11. 
    jgarzik commented at 9:40 am on October 1, 2015: contributor

    Nod - a pull request to change them all at once
12. laanwj merged this on Oct 1, 2015
13. laanwj closed this on Oct 1, 2015

    ---

14. laanwj referenced this in commit 19c7186425 on Oct 1, 2015
15. zkbot referenced this in commit 36df5a92f8 on Feb 9, 2017
16. zkbot referenced this in commit dd8b38316f on Feb 9, 2017
17. zkbot referenced this in commit 253c610783 on Feb 9, 2017
18. MarcoFalke locked this on Sep 8, 2021

Contributors
paveljanik jonasschnelli jgarzik laanwj

Labels
Docs