Document pull-req #6424 in release-notes #6751

pull petertodd wants to merge 1 commits into bitcoin:master from petertodd:pull-req-6424-release-notes changing 1 files +10 −0
  1. petertodd commented at 12:59 pm on October 3, 2015: contributor
  2. in doc/release-notes.md: in 2817dc9482 outdated
    104@@ -105,6 +105,16 @@ In this version, it is only enforced for peers that send protocol versions
    105 removed. It is recommended to update SPV clients to check for the `NODE_BLOOM`
    106 service bit for nodes that report versions newer than 70011.
    107 
    108+Any sequence of pushdatas in OP_RETURN outputs now allowed
    109+----------------------------------------------------------
    110+
    111+Previously OP_RETURN outputs with a payload were only relayed and mined if they
    112+had a single pushdata. This restriction has been lifted to allow any
    113+combination of data pushes and numeric constant opcodes. (OP_1 to OP_16) The
    


    paveljanik commented at 3:39 pm on October 3, 2015:
    The dot after parens?

    petertodd commented at 3:50 pm on October 3, 2015:
    Hmm? What specifically do you think I should change?

    paveljanik commented at 4:04 pm on October 3, 2015:
    0-constant opcodes. (OP_1 to OP_16)
    1+constant opcodes (OP_1 to OP_16).
    

    ie. move the dot at the end.


    petertodd commented at 4:21 pm on October 3, 2015:
    Ah! Sorry. Fixed.
  3. petertodd force-pushed on Oct 3, 2015
  4. in doc/release-notes.md: in c66472bf11 outdated
    110+
    111+Previously OP_RETURN outputs with a payload were only relayed and mined if they
    112+had a single pushdata. This restriction has been lifted to allow any
    113+combination of data pushes and numeric constant opcodes (OP_1 to OP_16). The
    114+limit on OP_RETURN output size is now applied to the entire serialized
    115+scriptPubKey, 83 bytes by default. (the previous 80 byte default plus three
    


    paveljanik commented at 4:29 pm on October 3, 2015:
    The same here. Sorry, I haven’t seen it at first somehow.
  5. jonasschnelli commented at 4:50 pm on October 3, 2015: contributor

    ACK.

    But I really would like to see git commit title/description understandable from a non github perspective. Keeping the mindset decentralized even at the place where the source code is managed is probably a good thing.

    As @laanwj once mentioned, the issue/PR number within a commit title/description is okay. But still it should be understandable from a non GitHub perspective.

  6. luke-jr commented at 4:59 pm on October 3, 2015: member
    +1 on a readable commit message.
  7. petertodd commented at 5:17 pm on October 3, 2015: contributor
    @jonasschnelli Sure, tell me what you want it to be and I’ll make it that.
  8. paveljanik commented at 5:31 pm on October 3, 2015: contributor
    What about: Mention now allowed sequence of pushdatas in OP_RETURN outputs in release notes.
  9. laanwj added the label Docs and Output on Oct 5, 2015
  10. Document pull-req #6424 in release-notes
    Mention now allowed sequence of pushdatas in OP_RETURN outputs in
    release notes.
    9204930101
  11. petertodd force-pushed on Oct 5, 2015
  12. petertodd commented at 10:13 pm on October 5, 2015: contributor
  13. laanwj merged this on Oct 6, 2015
  14. laanwj closed this on Oct 6, 2015

  15. laanwj referenced this in commit b6f3a4eb19 on Oct 6, 2015
  16. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-24 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me