Document pull-req #6424 in release-notes #6751

pull petertodd wants to merge 1 commits into bitcoin:master from petertodd:pull-req-6424-release-notes changing 1 files +10 −0

petertodd commented at 12:59 PM on October 3, 2015: contributor

No description provided.

in doc/release-notes.md:None in 2817dc9482 outdated

 104 | @@ -105,6 +105,16 @@ In this version, it is only enforced for peers that send protocol versions
 105 |  removed. It is recommended to update SPV clients to check for the `NODE_BLOOM`
 106 |  service bit for nodes that report versions newer than 70011.
 107 |  
 108 | +Any sequence of pushdatas in OP_RETURN outputs now allowed
 109 | +----------------------------------------------------------
 110 | +
 111 | +Previously OP_RETURN outputs with a payload were only relayed and mined if they
 112 | +had a single pushdata. This restriction has been lifted to allow any
 113 | +combination of data pushes and numeric constant opcodes. (OP_1 to OP_16) The

paveljanik commented at 3:39 PM on October 3, 2015:

The dot after parens?

petertodd commented at 3:50 PM on October 3, 2015:

Hmm? What specifically do you think I should change?

paveljanik commented at 4:04 PM on October 3, 2015:

-constant opcodes. (OP_1 to OP_16)
+constant opcodes (OP_1 to OP_16).

ie. move the dot at the end.

petertodd commented at 4:21 PM on October 3, 2015:

Ah! Sorry. Fixed.

petertodd force-pushed on Oct 3, 2015

in doc/release-notes.md:None in c66472bf11 outdated

 110 | +
 111 | +Previously OP_RETURN outputs with a payload were only relayed and mined if they
 112 | +had a single pushdata. This restriction has been lifted to allow any
 113 | +combination of data pushes and numeric constant opcodes (OP_1 to OP_16). The
 114 | +limit on OP_RETURN output size is now applied to the entire serialized
 115 | +scriptPubKey, 83 bytes by default. (the previous 80 byte default plus three

paveljanik commented at 4:29 PM on October 3, 2015:

The same here. Sorry, I haven't seen it at first somehow.

jonasschnelli commented at 4:50 PM on October 3, 2015: contributor

ACK.

But I really would like to see git commit title/description understandable from a non github perspective. Keeping the mindset decentralized even at the place where the source code is managed is probably a good thing.

As @laanwj once mentioned, the issue/PR number within a commit title/description is okay. But still it should be understandable from a non GitHub perspective.
luke-jr commented at 4:59 PM on October 3, 2015: member

+1 on a readable commit message.
petertodd commented at 5:17 PM on October 3, 2015: contributor

@jonasschnelli Sure, tell me what you want it to be and I'll make it that.
paveljanik commented at 5:31 PM on October 3, 2015: contributor

What about: Mention now allowed sequence of pushdatas in OP_RETURN outputs in release notes.
laanwj added the label Docs and Output on Oct 5, 2015

Document pull-req #6424 in release-notes

Mention now allowed sequence of pushdatas in OP_RETURN outputs in
release notes.

9204930101

petertodd force-pushed on Oct 5, 2015
petertodd commented at 10:13 PM on October 5, 2015: contributor

@paveljanik done
laanwj merged this on Oct 6, 2015
laanwj closed this on Oct 6, 2015
laanwj referenced this in commit b6f3a4eb19 on Oct 6, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels