Qt displays some coinjoin transactions incorrectly #6814

issue dooglus openend this issue on October 13, 2015
  1. dooglus commented at 2:57 am on October 13, 2015: contributor

    TransactionRecord::decomposeTransaction() in qt/transactionrecord.cpp refuses to “break down payees” if !fAllFromMe && !fAllToMe, since it recognises it as a “Mixed debit transaction”.

    This is all well and good, but if the transaction is a net gain for the wallet none of that logic runs:

    0if (nNet > 0 || wtx.IsCoinBase())
    1    // (ignore all that stuff)
    

    The assumption seems to be that if the transaction results in a net gain then none of the inputs could have been ours originally and so can be ignored. Each row in the transaction list shows just the size of the corresponding output and ignores the sum of our contributions to the inputs:

    0sub.credit = txout.nValue;
    

    Replacing the:

    0if (nNet > 0 || wtx.IsCoinBase())
    

    with just:

    0if (wtx.IsCoinBase())
    

    produces a more accurate (if terse) display.

  2. laanwj added the label GUI on Oct 13, 2015
  3. diegoviola commented at 1:39 am on October 31, 2015: contributor
    It’s spelled Qt.
  4. dooglus renamed this:
    QT displays some coinjoin transactions incorrectly
    Qt displays some coinjoin transactions incorrectly
    on Oct 31, 2015
  5. laanwj commented at 10:31 am on November 1, 2015: member
    @diegoviola it would be more helpful if you’d help diagnosing the issues instead of playing spell checker …
  6. fanquake deleted a comment on Mar 21, 2019
  7. MarcoFalke commented at 8:16 pm on April 24, 2020: member

    This is fixed: #10173 (comment)?

    Is this still an issue with a recent version of Bitcoin Core? If yes, what are the steps to reproduce?

  8. MarcoFalke closed this on Apr 24, 2020

  9. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 16:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me