WIP: force zeromq to work with static linking+mingw #6819

pull theuni wants to merge 1 commits into bitcoin:master from theuni:zeromq-mingw changing 5 files +43 −3

theuni commented at 5:16 PM on October 13, 2015: member

I have no idea if this actually works, it's only meant to be enough link a binary. This needs a good bit of testing on Windows before merge.
theuni commented at 5:16 PM on October 13, 2015: member

ping @jmcorgan @jonasschnelli

build: force zeromq to work with static linking+mingw

I have no idea if this actually works, it's only meant to be enough link
a binary.

d65eb63fc8

luke-jr commented at 5:22 PM on October 13, 2015: member

What? Why? Static linking makes sense for the Linux binaries, but not for Mac/Windows. It certainly shouldn't break non-static builds either way!

theuni commented at 5:23 PM on October 13, 2015: member

as mentioned on IRC, the zmq rpc tests currently yield:

Running testscript zmq_test.py...
Initializing test directory /tmp/ramfs/tmp/testnnj2Pf
Assertion failed!

Program: Z:\home\cory\dev\bitcoin2\src\bitcoind.exe
File: zmq/zmqpublishnotifier.cpp, Line 91

Expression: psocket

abnormal program termination

With that assertion removed, it (appears to) finish successfully.

luke-jr commented at 5:25 PM on October 13, 2015: member

I don't see how that is at all related to this PR...
theuni commented at 5:25 PM on October 13, 2015: member

@luke-jr We make the same assumption about miniupnpc for sure, and i believe there are assumptions for boost/qt as well.

I could make the -DZMQ_STATIC an artifact of depends instead though, if you'd prefer.
theuni commented at 5:26 PM on October 13, 2015: member

@luke-jr Our tests have never been run against zmq+windows binaries afaik.
luke-jr commented at 5:30 PM on October 13, 2015: member

But that assertion/problem seems entirely unrelated to static linking...?
theuni commented at 5:35 PM on October 13, 2015: member

@luke-jr I'm not aware of anyone running the tests against libzmq dll's via mingw either. Assuming the problem isn't local, I assumed it was a windows issue.

Regardless, I'm just reporting what I saw :)
jonasschnelli commented at 6:28 PM on October 13, 2015: contributor

Nice! Concept ACK.
jmcorgan commented at 6:39 PM on October 13, 2015: contributor

I'll have to replicate @theuni test failure, then I'll dig into this.
laanwj commented at 11:00 AM on October 15, 2015: member

Static linking makes sense for the Linux binaries, but not for Mac/Windows

We link all dependency libraries statically on Windows and Mac as well as Linux. On no platform do we actually perform a 'static build' as this would mess with ASLR...
laanwj added the label Build system on Oct 20, 2015
laanwj commented at 6:29 AM on November 2, 2015: member

Any progress here?
jmcorgan commented at 4:42 PM on November 2, 2015: contributor

Last chat with @theuni on IRC he hadn't returned to the issue, nor have I.
laanwj commented at 9:55 AM on December 3, 2015: member

Does this have to be solved before the 0.12 release?
theuni commented at 4:50 AM on December 4, 2015: member

I'm not familiar enough with zmq to know how helpful it is in Windows. My hunch is that the overlap would be small enough to ignore until someone willing/able to test comes along.

I'd rather that than blindly enable it and risk untested codepaths.
laanwj commented at 8:50 AM on December 4, 2015: member

OK, yes, zmq on windows doesn't seem like a very common use-case. Thanks for the explanation.

(I'm not even convinced it should be enabled in any releases by default, I mean it has to statically link zmq instead of use the one on the system, which may be incompatible in practice)
laanwj commented at 2:55 PM on January 22, 2016: member

Closing this for now, as it seems to be inactive. Let me know if you start work on this again so I can reopen.
laanwj closed this on Feb 3, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8238 [WIP][depends] ZeroMQ 4.1.5 && ZMQ on Windows