[rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase #6828

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-fundrawtransactionTestFix changing 1 files +9 −1

MarcoFalke commented at 12:33 PM on October 14, 2015: member

minRelayTxFee was bumped in #6793 but the rpc test were not updated.

Related to #6827. (@laanwj should decide which one to merge first)

in qa/rpc-tests/fundrawtransaction.py:None in 372c2a9ac0 outdated

  27 | @@ -28,7 +28,10 @@ def setup_network(self, split=False):
  28 |  
  29 |      def run_test(self):
  30 |          print "Mining blocks..."
  31 | -        feeTolerance = Decimal(0.00000002) #if the fee's positive delta is higher than this value tests will fail, neg. delta always fail the tests
  32 | +
  33 | +        # if the fee's positive delta is higher than this value tests will fail, neg. delta always fail the tests
  34 | +        #            = 2 bytes * minRelayTxFeePerByte
  35 | +        feeTolerance = 2 * Decimal('0.00005000')/1000

dexX7 commented at 4:32 PM on October 15, 2015:

Maybe you could use the client's "relayfee" provided via "getnetworkinfo", so the test depends less on magic numbers?

MarcoFalke force-pushed on Oct 15, 2015
[rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase 0d8b1759d2
MarcoFalke force-pushed on Oct 20, 2015
laanwj closed this on Oct 20, 2015
laanwj merged this on Oct 20, 2015
MarcoFalke deleted the branch on Oct 20, 2015
furszy referenced this in commit 0724bbbad2 on Jun 28, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

MarcoFalke

dexX7

Linked (view graph)

#6793 Bump minrelaytxfee default #6827 [rpc-tests] Check return code