Increase fee in pruning.py RPC test #6841

This broke when we raised the min relay rate. This should probably be backported to 0.11. Fixes #6834.

utACK. Test is running now.

What about using the "relayfee" provided via "getnetworkinfo" as suggested by @dexX7? Also you may append "Fixes #6834" to the PR's OP.

@MarcoFalke good idea. done.

utACK b6d5e32

Hmm... test won't run on my end:

:~/node/bitcoin$ ./qa/pull-tester/rpc-tests.py pruning
Running 2nd level testscript pruning.py...
Initializing test directory /tmp/testtSK9Jx
Warning! This test requires 4GB of disk space and takes over 30 mins (up to 2 hours)
Mining a big blockchain of 995 blocks
Check that we haven't started pruning yet because we're below PruneAfterHeight
Success
Though we're already using more than 550MB, current usage: 590
Mining 25 more blocks should cause the first block file to be pruned
Success
Usage should be below target: 479  
Check that we'll exceed disk space target if we have a very high stale block rate
Mine 24 (stale) blocks on Node 1, followed by 25 (main chain) block reorg from Node 0, for 12 rounds
Usage can be over target because of high stale rate: 638
Check that we can survive a 288 block reorg still
Current block height: 1320
Invalidating block at height: 1033 2d671d7c2d0bf06c1514b40b6d2e2388f593262020b6c90a99b28f924b340392
New best height 1032
Generating new longer chain of 300 more blocks
Reconnect nodes
bitcoind: sync.cpp:112: void potential_deadlock_detected(const std::pair<void*, void*>&, const LockStack&, const LockStack&): Assertion `onlyMaybeDeadlock' failed.
Unexpected exception caught during testing: [Errno 111] Connection refused
  File "/home/gitian/node/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 118, in main
    self.run_test()
  File "/home/gitian/node/bitcoin/qa/rpc-tests/pruning.py", line 304, in run_test
    (self.forkheight,self.forkhash) = self.reorg_test() #(1033, )
  File "/home/gitian/node/bitcoin/qa/rpc-tests/pruning.py", line 172, in reorg_test
    sync_blocks(self.nodes[0:3])
  File "/home/gitian/node/bitcoin/qa/rpc-tests/test_framework/util.py", line 40, in sync_blocks
    counts = [ x.getblockcount() for x in rpc_connections ]
  File "/home/gitian/node/bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 138, in __call__
    response = self._request('POST', self.__url.path, postdata)
  File "/home/gitian/node/bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 124, in _request
    self.__conn.request(method, path, postdata, headers)
  File "/usr/lib/python2.7/httplib.py", line 1001, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python2.7/httplib.py", line 1035, in _send_request
    self.endheaders(body)
  File "/usr/lib/python2.7/httplib.py", line 997, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python2.7/httplib.py", line 850, in _send_output
    self.send(msg)
  File "/usr/lib/python2.7/httplib.py", line 812, in send
    self.connect()
  File "/usr/lib/python2.7/httplib.py", line 793, in connect
    self.timeout, self.source_address)
  File "/usr/lib/python2.7/socket.py", line 571, in create_connection
    raise err
Stopping nodes
Traceback (most recent call last):
  File "/home/gitian/node/bitcoin/qa/rpc-tests/pruning.py", line 359, in <module>
    PruneTest().main()
  File "/home/gitian/node/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 134, in main
    stop_nodes(self.nodes)
  File "/home/gitian/node/bitcoin/qa/rpc-tests/test_framework/util.py", line 218, in stop_nodes
    node.stop()
  File "/home/gitian/node/bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 138, in __call__
    response = self._request('POST', self.__url.path, postdata)
  File "/home/gitian/node/bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 119, in _request
    self.__conn.request(method, path, postdata, headers)
  File "/usr/lib/python2.7/httplib.py", line 1001, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python2.7/httplib.py", line 1029, in _send_request
    self.putrequest(method, url, **skips)
  File "/usr/lib/python2.7/httplib.py", line 892, in putrequest
    raise CannotSendRequest()
httplib.CannotSendRequest

My head is:

commit b6d5e32e0e5b038c6ff7e2ab5221b10727722341
Author: Alex Morcos <morcos@chaincode.com>

@jonasschnelli Seems unrelated to this pull. Can you reproduce the above problem?

I get for b6d5e32:

$ git log --oneline -1
b6d5e32 Make fee aware of min relay in pruning.py RPC test

$ qa/pull-tester/rpc-tests.py pruning --tmpdir=/var/tmp/BTC
Running 2nd level testscript pruning.py...
Initializing test directory /var/tmp/BTC
Warning! This test requires 4GB of disk space and takes over 30 mins (up to 2 hours)
Mining a big blockchain of 995 blocks
Check that we haven't started pruning yet because we're below PruneAfterHeight
Success
Though we're already using more than 550MB, current usage: 590
Mining 25 more blocks should cause the first block file to be pruned
Success
Usage should be below target: 479
Check that we'll exceed disk space target if we have a very high stale block rate
Mine 24 (stale) blocks on Node 1, followed by 25 (main chain) block reorg from Node 0, for 12 rounds
Usage can be over target because of high stale rate: 638
Check that we can survive a 288 block reorg still
Current block height: 1320
Invalidating block at height: 1033 423699603f0fe282968c6b7705e431aa44a655e2a511854d6cf1750d5505430a
New best height 1032
Generating new longer chain of 300 more blocks
Reconnect nodes
Verify height on node 2: 1332
Usage possibly still high bc of stale blocks in block files: 638
Mine 220 more blocks so we have requisite history (some blocks will be big and cause pruning of previous chain)
Usage should be below target: 447
Test that we can rerequest a block we previously pruned if needed for a reorg
Will need to redownload block 1033
Rewind node 0 to prev main chain to mine longer chain to trigger redownload. Blocks needed: 233
Verify node 2 reorged back to the main chain, some blocks of which it had to redownload
Done
Stopping nodes
Cleaning up
Tests successful