[qt] Update coin control and smartfee labels #6887

1. 
   MarcoFalke commented at 1:09 am on October 25, 2015: member

   This will sync the qt labels with the wallet’s fee code.
2. 
   luke-jr commented at 1:50 am on October 25, 2015: member

   So the idea here is to use the min relay fee instead of the wallet’s configured fee, whichever is higher?
3. 
   MarcoFalke commented at 1:51 am on October 25, 2015: member

   Yes, it’s just what the wallet already does. This should make qt consistent again. C.f.

   • 037b4f1485404a69f96ac6c448a97d21315c8663 (Make mining fee policy match relay fee policy) and
   • aa279d613152e87ea25edfdf76c86779c0632f18 (Enforce minRelayTxFee on wallet created tx)
4. laanwj added the label GUI on Oct 26, 2015
5. 
   jgarzik commented at 7:24 pm on October 27, 2015: contributor

   ut ACK
6. in src/wallet/wallet.cpp: in 745661825a outdated

   2119@@ -2120,6 +2120,11 @@ bool CWallet::CommitTransaction(CWalletTx& wtxNew, CReserveKey& reservekey)
   2120     return true;
   2121 }
   2122 
   2123+CAmount CWallet::GetRequiredFee(unsigned int nTxBytes)
   2124+{
   2125+    return std::max(minTxFee.GetFee(nTxBytes), ::minRelayTxFee.GetFee(nTxBytes));
   

   ---

   ---

   

   jonasschnelli commented at 7:01 pm on October 29, 2015:

   Sad to see another coupling between the Wallet and the Mempool/Node. But it’s already all over. Ideally the wallet should not directly access global mempool variables instead it should get data over a general interface.
7. 
   jonasschnelli commented at 7:02 pm on October 29, 2015: contributor

   Makes sense. utACK.
8. [qt] Properly display required fee instead of minTxFee abd8b768ee
9. Clarify what minrelaytxfee does 53238ff0b1
10. MarcoFalke force-pushed on Nov 3, 2015
11. 
    MarcoFalke commented at 8:35 am on November 3, 2015: member

    @morcos This is addressing your issue #5202. Mind to review?
12. 
    morcos commented at 9:35 pm on November 3, 2015: member

    I think most of the pull makes sense, but I’d save removing the AbsurdFee check until we replace it with something better. Having the only effective high fee check be the ATMP check is dicey since that depends on minRelayTxFee which people might be adjusting for other reasons. Also I’m not sure how this is meant to work with #6726. I don’t like the idea of having less and less checks for accidental high fees. I just think we should rework them to be better organized.
13. 
    laanwj commented at 10:27 am on November 4, 2015: member

    I agree with @morcos. The absurdfee check is just a belt-and-suspenders check, in case something goes wrong due to a bug in another part of the code. I don’t feel good about removing it. I also don’t think that change belongs in a “Update coin control and smartfee labels” pull.
14. MarcoFalke force-pushed on Nov 4, 2015
15. 
    MarcoFalke commented at 11:21 am on November 4, 2015: member

    @laanwj I also don’t think that change belongs in a “Update coin control and smartfee labels” pull.

    Still, the fee label behaves wrong and needs update, but I force dropped the last commit to open a new PR for this…

16. laanwj merged this on Nov 5, 2015
17. laanwj closed this on Nov 5, 2015

    ---

18. laanwj referenced this in commit 3694b74fa9 on Nov 5, 2015
19. MarcoFalke deleted the branch on Nov 5, 2015
20. zkbot referenced this in commit 8713d73daf on Dec 18, 2019
21. zkbot referenced this in commit 2da77edbfe on Dec 18, 2019
22. zkbot referenced this in commit 577f7ef72a on Dec 18, 2019
23. furszy referenced this in commit 7c102142c7 on Jun 2, 2020
24. MarcoFalke locked this on Sep 8, 2021

Contributors
MarcoFalke luke-jr jgarzik jonasschnelli morcos laanwj

Labels
GUI