Clear strMiscWarning before running PartitionAlert #6888

pull CodeShark wants to merge 1 commits into bitcoin:master from CodeShark:alert_tests changing 1 files +3 −1
  1. CodeShark commented at 9:49 AM on October 25, 2015: contributor

    I was getting strange travis errors earlier because some test that was running prior to PartitionAlert in alert_tests apparently was setting the strMiscWarning variable. Using a side effect such as this as an error handling mechanism is probably not a very good idea to begin with...but if we're going to do this, we should make sure to reset the variable before each call so we can tell which one set it.

    Note: The implication here is that something before the call on line 224 is setting this variable and we can't easily figure out what it is...which should probably also be fixed.

  2. Use BOOST_CHECK_MESSAGE() rather than BOOST_CHECK() in alerts_tests.cpp and initialize strMiscWarning before calling PartitionCheck()." 143d173969
  3. laanwj added the label Tests on Oct 26, 2015
  4. laanwj commented at 6:44 AM on October 26, 2015: member

    Agree strMiscWarning is terrible, see also #6809 Starting the test with a clean slate makes sense though. ACK.

  5. jtimon commented at 1:16 PM on October 26, 2015: contributor

    ACK

  6. btcdrak commented at 1:21 PM on October 26, 2015: contributor

    Tested ACK

  7. instagibbs commented at 4:03 PM on October 26, 2015: member

    utACK

  8. laanwj merged this on Oct 26, 2015
  9. laanwj closed this on Oct 26, 2015

  10. laanwj referenced this in commit c8322ff7f7 on Oct 26, 2015
  11. luke-jr referenced this in commit f8f1d08872 on Jan 9, 2016
  12. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me