forward-declare univalue in rpcclient + remove include in rpcserver.cpp #6893

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:univalue changing 2 files +4 −3

Diapolo commented at 4:54 PM on October 27, 2015: none

No description provided.
forward-declare univalue in rpcclient + remove include in rpcserver.cpp 74cd634b1d

in src/rpcserver.cpp:None in 74cd634b1d

  12 | @@ -13,8 +13,6 @@
  13 |  #include "util.h"
  14 |  #include "utilstrencodings.h"
  15 |  
  16 | -#include <univalue.h>

jonasschnelli commented at 5:02 PM on October 27, 2015:

Right. Not required, already in rpcserver.h.

jgarzik commented at 5:02 PM on October 27, 2015: contributor

ut ACK
in src/rpcclient.h:None in 74cd634b1d
```
   5 | @@ -6,7 +6,10 @@
   6 |  #ifndef BITCOIN_RPCCLIENT_H
   7 |  #define BITCOIN_RPCCLIENT_H
   8 |  
   9 | -#include <univalue.h>
  10 | +#include <string>
  11 | +#include <vector>
  12 | +
  13 | +class UniValue;
```
jonasschnelli commented at 5:03 PM on October 27, 2015:

This is not required. rpcclient.cpp has a #include <univalue.h>. Or do i miss something?

Diapolo commented at 5:06 PM on October 27, 2015:

Right, but try to just remove it and look at line below ;-).

jonasschnelli commented at 5:07 PM on October 27, 2015:

Nevermind. :)
jonasschnelli commented at 5:07 PM on October 27, 2015: contributor

code review ACK
sipa commented at 1:49 AM on October 28, 2015: member

Not a fan of forward declares, but meh.
laanwj commented at 12:29 PM on October 29, 2015: member

Meh, don't care
dcousens commented at 1:03 PM on October 29, 2015: contributor

Any motivation for this? utACK
laanwj commented at 11:34 PM on October 30, 2015: member

Closing this, I don't think there's really a point to make this change.
laanwj closed this on Oct 30, 2015
Diapolo commented at 8:46 AM on October 31, 2015: none

Even if this is just "meh", you could have waited for an update, so the unneeded include in rpcclient.h could've been removed...
jonasschnelli commented at 10:49 AM on October 31, 2015: contributor

Agree with @laanwj: please just stop these PRs. They just distract from the important ones. If you can't leave it, please use @theuni trivial branch.
DrahtBot locked this on Sep 8, 2021

Contributors