[Trivial] remove unneeded spaces from init.cpp #6921

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:trivial_typo_space changing 1 files +9 −9

Diapolo commented at 8:57 AM on October 31, 2015: none

No description provided.
[Trivial] remove unneeded spaces from init.cpp e953dd6d44
in src/init.cpp:None in e953dd6d44
```
 872 | @@ -873,7 +873,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
 873 |      nPruneTarget = (uint64_t) nSignedPruneTarget;
 874 |      if (nPruneTarget) {
 875 |          if (nPruneTarget < MIN_DISK_SPACE_FOR_BLOCK_FILES) {
 876 | -            return InitError(strprintf(_("Prune configured below the minimum of %d MiB.  Please use a higher number."), MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024));
 877 | +            return InitError(strprintf(_("Prune configured below the minimum of %d MiB. Please use a higher number."), MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024));
```
MarcoFalke commented at 8:59 AM on October 31, 2015:

I did not touch this last time because the translation was already done. Am I wrong?

Diapolo commented at 9:03 AM on October 31, 2015:

IMHO your changes with removing the "Error:" in front require a few re-translations, so that shouldn't matter.

MarcoFalke commented at 9:08 AM on October 31, 2015:

Right, ACK on this one.

MarcoFalke commented at 9:59 AM on October 31, 2015:

@Diapolo Maybe just get in this change? You can either force push it or wait until I submit my trivial branch (~every two weeks) with the trivial changes cherry-picked and bundled up.

in src/init.cpp:None in e953dd6d44

1280 | @@ -1281,10 +1281,10 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
1281 |                      break;
1282 |                  }
1283 |  
1284 | -                // Check for changed -prune state.  What we are concerned about is a user who has pruned blocks
1285 | +                // Check for changed -prune state. What we are concerned about is a user who has pruned blocks
1286 |                  // in the past, but is now trying to run unpruned.
1287 |                  if (fHavePruned && !fPruneMode) {
1288 | -                    strLoadError = _("You need to rebuild the database using -reindex to go back to unpruned mode.  This will redownload the entire blockchain");
1289 | +                    strLoadError = _("You need to rebuild the database using -reindex to go back to unpruned mode. This will redownload the entire blockchain");

MarcoFalke commented at 9:09 AM on October 31, 2015:

This would trigger new translations? So I'd NACK this one.

MarcoFalke commented at 9:13 AM on October 31, 2015: member

Do we care about white space in comments? @laanwj said this will break git blame.
Diapolo commented at 9:16 AM on October 31, 2015: none

Sometimes I'm asking myself, why it seems just my trivial pulls create controversial discussions ^^. @MarcoFalke If this gets NACKed in general, fell free to pick it up.
laanwj commented at 9:51 AM on October 31, 2015: member

Sometimes I'm asking myself, why it seems just my trivial pulls create controversial discussions ^^

Because, to be entirely honest, all this trivial fudging around with spaces tends to annoy me as long as there are still 341 actual issues to be solved.
laanwj closed this on Oct 31, 2015
btcdrak commented at 10:39 AM on October 31, 2015: contributor

I think what would help going forward is to have some sort of simple CS checker as part of the continuous integration like travis, then less CS issues would get into the codebase in the first place.
Diapolo deleted the branch on Oct 31, 2015
DrahtBot locked this on Sep 8, 2021

Contributors