minor updates/changes in txmempool.h/.cpp #6922

pull Diapolo wants to merge 3 commits into bitcoin:master from Diapolo:txmempool changing 2 files +19 −20

Diapolo commented at 9:14 AM on October 31, 2015: none

No description provided.
Use const ref in PrioritiseTransaction, update logging
- make the logging in PrioritiseTransaction() use __func__
6bbfbbb1cb
add std:: where missing and prevent std namespace pollution 959bb93dde
use correct format for function definitions 9814f52cdf
paveljanik commented at 10:39 AM on October 31, 2015: contributor

@Diapolo are you willing to maintain and constantly rebase the "cleanup" branch of bitcoin? Ie. include all const changes, whitespace changes, clang-format changes etc. in your own tree? Let's try it for a month or so...

in src/txmempool.cpp:None in 9814f52cdf

 744 | @@ -750,7 +745,7 @@ void CTxMemPool::PrioritiseTransaction(const uint256 hash, const string strHash,
 745 |          deltas.first += dPriorityDelta;
 746 |          deltas.second += nFeeDelta;
 747 |      }
 748 | -    LogPrintf("PrioritiseTransaction: %s priority += %f, fee += %d\n", strHash, dPriorityDelta, FormatMoney(nFeeDelta));
 749 | +    LogPrintf("%s: %s priority += %f, fee += %d\n", __func__, strHash, dPriorityDelta, FormatMoney(nFeeDelta));

dcousens commented at 10:51 AM on October 31, 2015:

This hardly seems worth it

in src/txmempool.cpp:None in 9814f52cdf

 774 | @@ -780,7 +775,8 @@ bool CTxMemPool::HasNoInputsOf(const CTransaction &tx) const
 775 |  
 776 |  CCoinsViewMemPool::CCoinsViewMemPool(CCoinsView *baseIn, CTxMemPool &mempoolIn) : CCoinsViewBacked(baseIn), mempool(mempoolIn) { }
 777 |  
 778 | -bool CCoinsViewMemPool::GetCoins(const uint256 &txid, CCoins &coins) const {
 779 | +bool CCoinsViewMemPool::GetCoins(const uint256 &txid, CCoins &coins) const

dcousens commented at 10:53 AM on October 31, 2015:

Your & syntax alternates too

dcousens commented at 10:54 AM on October 31, 2015: contributor

Trivial, utACK, but, meh
Diapolo closed this on Oct 31, 2015
Diapolo deleted the branch on Oct 31, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

paveljanik

dcousens