Improving labels for Sent / Received "Bytes" #6940

pull jonathancross wants to merge 1 commits into bitcoin:master from jonathancross:patch-1 changing 1 files +2 −2

jonathancross commented at 7:18 PM on November 4, 2015: contributor
The labels for Sent & Received data in the "Peers" debug panel should not be defined as "Bytes" because the units (B, KB, MB) appear after the number making this redundant. I decided to simply use "Sent" and "Received" (rather than "Data Sent" and "Data Received") because we already have translations for the former. Japanese example: https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=sent https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=received

Demo of changes:

Current UI:
```
Bytes Sent      12 KB
Bytes Received  26 MB
```
With this pull request:
```
Sent       12 KB
Received   26 MB
```
Happy to add a screenshot if it would help.

Improving labels for Sent / Received "Bytes"

The labels for Sent & Received data in the "Peers" debug panel should not be defined as "Bytes" because the units (B, KB, MB) appear after the number.  I decided to simply use "Sent" and "Received" (rather than "Data Sent" and "Data Received") because we already have translations for the former:
https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=sent
https://www.transifex.com/bitcoin/bitcoin/viewstrings/#ja/qt-translation-011x/47533089?q=received

Demo of changes:

Current UI:
    Bytes Sent      12 KB
    Bytes Received  26 MB

With this pull request:
    Sent       12 KB
    Received   26 MB

7ca73dcf6b

jonasschnelli commented at 7:22 PM on November 4, 2015: contributor

Bytes Send: 1MB seems still logical to me (Megabytes are also bytes). I personally like the "Bytes" in front of Send and Receive because it will quickly allow one to identify that it is related to "traffic".
MarcoFalke commented at 7:08 PM on November 5, 2015: member

use "Sent" and "Received" (rather than "Data Sent" and "Data Received") because we already have translations for the former.

Still, I'd prefer "Data *" or just keep "Bytes *" because you can also send packets or messages or...
laanwj added the label Wallet on Nov 5, 2015
laanwj commented at 10:55 PM on November 5, 2015: member

I'm ok with this change, "bytes" is indeed redundant, the unit speaks for itself. ACK
laanwj added the label GUI on Nov 9, 2015
laanwj removed the label Wallet on Nov 9, 2015
laanwj merged this on Nov 10, 2015
laanwj closed this on Nov 10, 2015
laanwj referenced this in commit 32d8b1570c on Nov 10, 2015
jonathancross deleted the branch on Feb 27, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels