The docs talk about bits 2 and 4 instead of 2 and 3, and bits are being indexed from both 1 (describing nCode) and 0 (in second example). Changed to use zero-indexing for all.
Fix CCoins serialization documentation #6942
pull peterjosling wants to merge 1 commits into bitcoin:master from peterjosling:docfix changing 1 files +5 −5-
peterjosling commented at 8:17 PM on November 4, 2015: contributor
-
e482a7fe6b
Fix CCoins serialization documentation
The docs talk about bits 2 and 4 instead of 2 and 3, and bits are being indexed from both 1 (describing nCode) and 0 (in second example). Changed to use zero-indexing for all.
-
sipa commented at 8:21 PM on November 4, 2015: member
The documentation is intended to say "bits with value 1, 2, 4, ...", not their position.
-
peterjosling commented at 8:30 PM on November 4, 2015: contributor
Ah, that makes sense. I thought I must be missing something. It still doesn't seem very clear to me though - the second example describes "bits 2 (0x04) and 14 (0x4000)".
-
sipa commented at 8:53 PM on November 4, 2015: member
Agree, that's confusing. Feel free to rewrite into something clearer :)
-
laanwj commented at 9:56 PM on November 4, 2015: member
I also got confused by the bit notation but the text is correct (clarification would be welcome, absolutely).
- laanwj added the label Docs and Output on Nov 11, 2015
- sipa merged this on Nov 28, 2015
- sipa closed this on Nov 28, 2015
- sipa referenced this in commit 92aa7311d6 on Nov 28, 2015
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels