[trivial] White space, clang-format and docs #6955

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-trivial4 changing 4 files +17 −10

MarcoFalke commented at 9:42 PM on November 5, 2015: member
Rendered diff:
- Before: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions-ubuntu--debian
- After: https://github.com/MarcoFalke/bitcoin/blob/4bd96aaf9fa7e4cf7c4e9c451a33dc41aba2553c/doc/build-unix.md#dependency-build-instructions-ubuntu--debian
.clang-format change:
- E.g. d2da9395c946bfe2d87694f2e0a2992fbd963349
devtools: Update README.md 0af8fe45ae

in src/init.cpp:None in 4bd96aaf9f outdated

 875 | @@ -876,7 +876,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)
 876 |      nPruneTarget = (uint64_t) nSignedPruneTarget;
 877 |      if (nPruneTarget) {
 878 |          if (nPruneTarget < MIN_DISK_SPACE_FOR_BLOCK_FILES) {
 879 | -            return InitError(strprintf(_("Prune configured below the minimum of %d MiB.  Please use a higher number."), MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024));
 880 | +            return InitError(strprintf(_("Prune configured below the minimum of %d MiB. Please use a higher number."), MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024));

laanwj commented at 9:44 PM on November 5, 2015:

NACK, please don't change this translation message without good reason. Spaces get collapsed on rendering anyway.

MarcoFalke commented at 9:48 PM on November 5, 2015:

Translation was triggered when I fixed MB to MiB. So it shouldn't matter?

laanwj commented at 10:13 PM on November 5, 2015:

I just think it's bullshit to change a translation message just to mess with spaces.

laanwj commented at 9:45 PM on November 5, 2015: member

ACK apart from the translation message change
MarcoFalke force-pushed on Nov 5, 2015
dcousens commented at 9:50 PM on November 5, 2015: contributor

ACK
MarcoFalke force-pushed on Nov 5, 2015
[trivial] clang-format: Set AlignAfterOpenBracket: false e0eeb672f2
[doc] Remove excessive white space e167af2acd
MarcoFalke force-pushed on Nov 5, 2015
laanwj merged this on Nov 5, 2015
laanwj closed this on Nov 5, 2015
laanwj referenced this in commit 4ee149a6db on Nov 5, 2015
MarcoFalke deleted the branch on Nov 5, 2015
in src/.clang-format:None in e167af2acd
```
  27 | @@ -26,7 +28,6 @@ IndentCaseLabels: false
  28 |  IndentFunctionDeclarationAfterType: false
  29 |  IndentWidth:     4
  30 |  KeepEmptyLinesAtTheStartOfBlocks: false
  31 | -Language:        Cpp
```
jonasschnelli commented at 7:30 AM on November 6, 2015:

What's the effect of removing Cpp as language? Does it autodetect c++ or is it the default in all recent clang-format versions?

MarcoFalke commented at 7:41 AM on November 6, 2015:

I moved it to the top. But as we are only using cpp it does not matter.

Doc:

The configuration file can consist of several sections each having different Language: parameter denoting the programming language this section of the configuration is targeted at. [...] The first section may have no language set, it will set the default style options for all lanugages.

jonasschnelli commented at 7:42 AM on November 6, 2015:

Sorry for the noise. I didn't see that in the first place. ACK.
MarcoFalke locked this on Sep 8, 2021

Contributors