Don't use hard-coded AllowFree, as this is usually far too low. #6997

pull sturles wants to merge 1 commits into bitcoin:master from sturles:no-default-free-priority changing 1 files +5 −3
  1. sturles commented at 12:06 PM on November 12, 2015: none

    Try to find a better estimate for the priority needed for a free transaction within the next few confirmation targets, or just fall back to add a fee if unsuccessful.

    Something similar should probably be done with the default fee, since the default is usually much lower than what estimatefee 2 recommends if estimatefee 1 fails. On the other hand estimatefee usually recommends a much higher fee than actually required for the confirmation target, and this may lead to artificial fee inflation. When a transaction using the recommended fee/priority doesn't go through in the first block, there is usually something else, e.g. individual miner policy, preventing it.

  2. Don't use hard-coded AllowFree, as this is usually far too low. Try to
    find a better estimate within the next few confirmation targets, or just
    fail back to add a fee if unsuccessful.
    227861eda6
  3. morcos commented at 12:11 PM on November 12, 2015: member

    This logic is already included in a more complete way in #6134 (which replaced #6131)

  4. sturles commented at 12:39 PM on November 12, 2015: none

    @morcos Correct, however your latest commit in #6134 depends on, and tries to work around the current mempool trimming bug in a way that only works for one special case. A better approach would be to fix mempool trimming by making it aware of priority. (As long as priority is a supported concept, if not priority should be removed entirely, not by introducing bugs to make it fail.)

  5. laanwj added the label Wallet on Nov 13, 2015
  6. morcos commented at 1:54 AM on December 2, 2015: member

    @laanwj this can be closed now that #6134 is merged

  7. jonasschnelli commented at 6:55 AM on December 2, 2015: contributor

    Superseded by #6134. Closing.

  8. jonasschnelli closed this on Dec 2, 2015

  9. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me