[Qt] add shortcurts for debug-/console-window #7000

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2015/11/qt_shortcuts changing 4 files +26 −0

jonasschnelli commented at 12:15 PM on November 12, 2015: contributor

Opening the console- or the debug-window (info tab) seems to be a action that many users do often. This PR adds a shortcut for opening the debug window (shift-ctrl-D) and one for showing directly the console (shift-ctrl-C). Considered to be a undocumented expert feature.
laanwj commented at 12:21 PM on November 12, 2015: member

utACK
in src/qt/bitcoingui.cpp:None in 08ed38b8cb outdated
```
 364 | @@ -364,6 +365,9 @@ void BitcoinGUI::createActions()
 365 |          connect(openAction, SIGNAL(triggered()), this, SLOT(openClicked()));
 366 |      }
 367 |  #endif // ENABLE_WALLET
 368 | +
 369 | +    new QShortcut(QKeySequence(Qt::CTRL + Qt::SHIFT + Qt::Key_C), this, SLOT(showDebugWindowActivateConsole()));
```
laanwj commented at 12:22 PM on November 12, 2015:

This looks weird, allocating a freely-floating object, but I do think it is correct. The object will become a child of *this, and automatically freed with it.

jonasschnelli commented at 12:29 PM on November 12, 2015:

Right. It looks a bit strange. But i think it should compile fine and leaves no men-leak (and requires less code).
paveljanik commented at 12:32 PM on November 12, 2015: contributor

But anyway - 7000 is yours!
paveljanik commented at 12:32 PM on November 12, 2015: contributor

BTW - will test on OS X later today - Ctrl key...
jonasschnelli commented at 12:39 PM on November 12, 2015: contributor

@paveljanik the problem with a parameter for showDebugWindow() is, that binding a parameter to a signal is non-trivial (requires a QSignalMapper) and result in a uncommon code. I have considered that but was going for the more clear way which not really involves more code line (maybe +2).

I have testes it on OSX. QT automaps the OSX-cmd key to ctrl. Needs testing on Linux/Windows.
jonasschnelli force-pushed on Nov 12, 2015
jonasschnelli commented at 12:42 PM on November 12, 2015: contributor

force push fixed @paveljanik's nits.
[Qt] add shortcurts for debug-/console-window 773ae4654e
jonasschnelli force-pushed on Nov 12, 2015
paveljanik commented at 1:19 PM on November 12, 2015: contributor

tested ACK
jonasschnelli referenced this in commit ddc90efaa8 on Nov 12, 2015
jonasschnelli commented at 4:33 PM on November 12, 2015: contributor

Binaries if someone likes to test this on Windows or Linux: https://bitcoin.jonasschnelli.ch/pulls/7000/
MarcoFalke commented at 5:15 PM on November 12, 2015: member

I need this!

tested ACK 773ae46
laanwj added the label RPC on Nov 13, 2015
jonasschnelli added the label GUI on Nov 13, 2015
jonasschnelli removed the label RPC on Nov 13, 2015
jonasschnelli commented at 2:43 PM on November 13, 2015: contributor

Just tested this also on Windows and Linux/Ubuntu. Works.
jonasschnelli merged this on Nov 16, 2015
jonasschnelli closed this on Nov 16, 2015
jonasschnelli referenced this in commit 814697c556 on Nov 16, 2015
luke-jr referenced this in commit e611ab1906 on Nov 27, 2015
rebroad commented at 4:02 PM on March 1, 2016: contributor

Why not document this?
laanwj commented at 4:58 PM on March 1, 2016: member

Hah, would be awesome if someone wrote a manual/help function for the GUI in the first place...
DrahtBot locked this on Sep 8, 2021

Contributors

Labels