There doesn't seem to be any reason for it to hold this lock.
Thoughts?
RPC: decodescript RPC call holds cs_main #7012
issue pstratem opened this issue on November 13, 2015-
pstratem commented at 10:08 PM on November 13, 2015: contributor
-
pstratem commented at 10:10 PM on November 13, 2015: contributor
@CodeShark 4401b2d7 why?
-
pstratem commented at 10:18 PM on November 13, 2015: contributor
@petertodd ping
-
-
-
petertodd commented at 10:25 PM on November 13, 2015: contributor
@CodeShark I just did that, although I'm in a bit of a rush so I may have missed something!
-
CodeShark commented at 2:51 AM on November 14, 2015: contributor
@petertodd thanks. The purpose of https://github.com/bitcoin/bitcoin/commit/4401b2d7c52e0f3841225369fb0d10767c51aaa2 wasn't to completely fix the locks - it was just to remove dependencies and provide for the ability to make the locks more granular without changing any behavior. There's still plenty that could be done to improve concurrency.
-
pstratem commented at 2:55 AM on November 14, 2015: contributor
@CodeShark ah i see
-
laanwj commented at 7:23 AM on November 14, 2015: member
@pstratem I didn't actually go through every single call and check whether it was actually thread-safe.
This was the longer-term goal of pushing down the locks in #5711, but for the first step it was much easier to review when doing a simple mechanical step, keeping the functionality the same. If it changed the locking for every single RPC call it would probably never have been merged.
- laanwj added the label RPC on Nov 14, 2015
-
- laanwj closed this on Nov 16, 2015
- MarcoFalke locked this on Sep 8, 2021
Labels