Implement helper class for CTxMemPoolEntry constructor #7020

pull morcos wants to merge 1 commits into bitcoin:master from morcos:EntryHelper changing 5 files +89 −47
  1. morcos commented at 2:26 am on November 15, 2015: member

    This is only for unit tests.

    This will make it easier to change the constructor to CTxMemPoolEntry in future changes, but also makes it more clear what values you are explicitly setting in the unit tests.

  2. sdaftuar commented at 4:40 pm on November 16, 2015: member
    Concept ACK. I think this will make writing/updating the tests less error-prone and more readable.
  3. dcousens commented at 0:51 am on November 17, 2015: contributor
    utACK
  4. Implement helper class for CTxMemPoolEntry constructor
    This is only for unit tests.
    e587bc3fd9
  5. morcos force-pushed on Nov 17, 2015
  6. morcos commented at 1:53 am on November 17, 2015: member
    Rebased. If people like this change, I think it would make sense to merge it sooner rather than later as it will really help with the merge conflicts between #6898 , #7008 , and #6915 which will hopefully all be in for 0.12.
  7. sdaftuar commented at 1:25 pm on November 17, 2015: member
    ACK, nice work. Agree that this would be nice to merge soon.
  8. laanwj added the label Tests on Nov 17, 2015
  9. laanwj commented at 4:57 pm on November 17, 2015: member
    utACK
  10. laanwj merged this on Nov 17, 2015
  11. laanwj closed this on Nov 17, 2015

  12. laanwj referenced this in commit e8df8a5077 on Nov 17, 2015
  13. zkbot referenced this in commit 6d6b780969 on Feb 20, 2018
  14. zkbot referenced this in commit 49274558c6 on Feb 20, 2018
  15. furszy referenced this in commit eb00d0f62f on Jun 14, 2020
  16. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 10:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me