[qa] rpc-tests: Properly use test framework #7027

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-rpcTestCleanup changing 1 files +57 −106

MarcoFalke commented at 12:25 PM on November 16, 2015: member

Some tests are not using the framework and thus are blocking some travis related PRs...

It is best to review this PR commit-by-commit. (Append the ?w=flag to white-space-only commits)
[qa] keypool: Fix white space to prepare transition to test framework c6973ca03b
[qa] keypool: DRY: Use test framework 4ea1790553
jonasschnelli added the label Tests on Nov 16, 2015
MarcoFalke force-pushed on Nov 19, 2015

MarcoFalke commented at 12:20 PM on November 26, 2015: member

Keypool is from #4347.

This fixes:

$ qa/pull-tester/rpc-tests.py keypool --coverage
Initializing coverage directory at /tmp/coveragerTt3hc
Running 2nd level testscript keypool.py...
Usage: keypool.py [options]

keypool.py: error: no such option: --coveragedir

sipa commented at 12:57 PM on November 28, 2015: member

utACK
MarcoFalke commented at 10:41 AM on November 30, 2015: member

@laanwj any reason you didn't do this as part of #4347?
laanwj commented at 11:12 AM on November 30, 2015: member

@laanwj any reason you didn't do this as part of #4347?

Probably didn't know about it yet, or even didn't exist yet when I started working on it.

utACK anyhow
laanwj merged this on Nov 30, 2015
laanwj closed this on Nov 30, 2015
laanwj referenced this in commit 6fc287f2df on Nov 30, 2015
MarcoFalke deleted the branch on Nov 30, 2015
zkbot referenced this in commit 025bd44543 on Nov 21, 2020
zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
zkbot referenced this in commit c8896f9907 on Dec 2, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels