torcontrol is noisy in debug.log if no Tor running #7032

issue laanwj opened this issue on November 16, 2015
  1. laanwj commented at 3:25 PM on November 16, 2015: member

    E.g.

    2015-11-16 15:18:25 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:18:26 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:18:27 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:18:30 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:18:33 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:18:38 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:18:46 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:18:57 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:19:14 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:19:40 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:20:19 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:21:16 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    2015-11-16 15:22:43 tor: Disconnected from Tor control port 127.0.0.1:9051, trying to reconnect
    

    Keeping trying to connect makes sense, as the user may (re)start Tor later. The exponential back-off is also clearly working. However, it shouldn't be logging this all the time (possibly only with -debug=tor), and a "disconnected" message is wrong if it cannot even connect.

  2. laanwj added the label P2P on Nov 16, 2015
  3. petertodd commented at 11:50 PM on November 16, 2015: contributor

    How about /s/Disconnected from/Not connected to/?

    Agreed on only logging with -debug=tor set.

  4. laanwj closed this on Nov 30, 2015

  5. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me