Fix ZMQ docs - Improve logging #7058

  71 | @@ -72,7 +72,7 @@ CZMQNotificationInterface* CZMQNotificationInterface::CreateWithArguments(const
  72 |  // Called at startup to conditionally set up ZMQ socket(s)
  73 |  bool CZMQNotificationInterface::Initialize()
  74 |  {
  75 | -    LogPrint("zmq", "Initialize notification interface\n");
  76 | +    LogPrint("zmq", "zmq: Initialize notification interface\n");

dcousens commented at 2:33 AM on November 19, 2015:

@laanwj maybe this should be done by LogPrint? Automatically prepend the category to the message? Thoughts?

jonasschnelli commented at 7:15 AM on November 19, 2015:

Right, this could be done by LogPrint (autoprint the category). But until then, it is probably best if we keep it consistent with other LogPrint's.

MarcoFalke commented at 11:10 AM on November 19, 2015:

Agree to get this done in the LogPrint method.

 433 | @@ -434,7 +434,7 @@ std::string HelpMessage(HelpMessageMode mode)
 434 |          strUsage += HelpMessageOpt("-limitdescendantcount=<n>", strprintf("Do not accept transactions if any ancestor would have <n> or more in-mempool descendants (default: %u)", DEFAULT_DESCENDANT_LIMIT));
 435 |          strUsage += HelpMessageOpt("-limitdescendantsize=<n>", strprintf("Do not accept transactions if any ancestor would have more than <n> kilobytes of in-mempool descendants (default: %u).", DEFAULT_DESCENDANT_SIZE_LIMIT));
 436 |      }
 437 | -    string debugCategories = "addrman, alert, bench, coindb, db, lock, rand, rpc, selectcoins, mempool, mempoolrej, net, proxy, prune, http, libevent"; // Don't translate these and qt below
 438 | +    string debugCategories = "addrman, alert, bench, coindb, db, lock, rand, rpc, selectcoins, mempool, mempoolrej, net, proxy, prune, http, libevent, zmq"; // Don't translate these and qt below
 439 |      if (mode == HMM_BITCOIN_QT)

jmcorgan commented at 3:12 AM on November 19, 2015:

Do you think the zmq system merits its own debug category? It's really the the first instance of a "notification" system, which might include other methods in the future.

It's not that big a deal; just double checking if this is the right way to go.

dcousens commented at 3:15 AM on November 19, 2015:

@jmcorgan this is already the case, I'm just exposing what is already there. If you want rename it to notifications:, sure.

These messages are helpful when debugging, absolutely.

laanwj commented at 9:45 AM on November 24, 2015:

@jmcorgan IMO it does. I think it's good to have different modules use a different debug category, even if they belong to the same logical grouping. Debugging is either very targeted 'I want to see this debug message' or 'I want to see all debugging messages', rarely in between.