http: add Boost 1.49 compatibility #7065

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_11_httpserver_boost1_49 changing 1 files +4 −0

laanwj commented at 9:24 AM on November 20, 2015: member

I'm not sure what versions of Boost we reasonably support, anyway,

try_join_for was introduced in Boost 1.50: http://www.boost.org/doc/libs/1_50_0/doc/html/thread/thread_management.html#thread.thread_management.thread.try_join_for

1.49 has timed_join, one can accomplish the same with: http://www.boost.org/doc/libs/1_49_0/doc/html/thread/thread_management.html#thread.thread_management.thread.timed_join

However, timed_join was deprecated in 1.50. So a conditional is necessary.

This solution was tested in #7031.

http: add Boost 1.49 compatibility

`try_join_for` was introduced in Boost 1.50:
http://www.boost.org/doc/libs/1_50_0/doc/html/thread/thread_management.html#thread.thread_management.thread.try_join_for

1.49 has `timed_join`, one can accomplish the same with:
http://www.boost.org/doc/libs/1_49_0/doc/html/thread/thread_management.html#thread.thread_management.thread.timed_join

However, `timed_join` was deprecated in 1.50. So a conditional is
necessary.

This solution was tested in #7031.

3522f49f5a

laanwj added the label RPC on Nov 20, 2015
MarcoFalke commented at 12:15 PM on November 20, 2015: member

utACK
jonasschnelli commented at 12:32 PM on November 20, 2015: contributor

Code Review ACK
jmcorgan commented at 2:06 PM on November 20, 2015: contributor

utACK
laanwj merged this on Nov 24, 2015
laanwj closed this on Nov 24, 2015
laanwj referenced this in commit f91e29fd4d on Nov 24, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7031 errors compiling httpserver.cpp