Replace-by-fee RPC test fails on master #7120

issue sipa openend this issue on November 27, 2015
  1. sipa commented at 8:21 pm on November 27, 2015: member
    0$ ./replace-by-fee.py 
    1Initializing test directory /tmp/testXh5dZU
    2Running test simple doublespend...
    3Running test doublespend chain...
    4JSONRPC error: 64: too-long-mempool-chain
    
  2. paveljanik commented at 2:39 pm on November 28, 2015: contributor

    This is because of

    0main.h:52:static const unsigned int DEFAULT_ANCESTOR_LIMIT = 25;
    

    The code starts with 50 COINs and spends 1 COIN until 10 COINs remain.

    This helps here:

     0diff --git a/qa/rpc-tests/replace-by-fee.py b/qa/rpc-tests/replace-by-fee.py
     1index 537a1ed..5c8b642 100755
     2--- a/qa/rpc-tests/replace-by-fee.py
     3+++ b/qa/rpc-tests/replace-by-fee.py
     4@@ -145,7 +145,7 @@ class ReplaceByFeeTest(BitcoinTestFramework):
     5     def test_doublespend_chain(self):
     6         """Doublespend of a long chain"""
     7
     8-        initial_nValue = 50*COIN
     9+        initial_nValue = 30*COIN
    10         tx0_outpoint = make_utxo(self.nodes[0], initial_nValue)
    11
    12         prevout = tx0_outpoint
    13@@ -162,10 +162,10 @@ class ReplaceByFeeTest(BitcoinTestFramework):
    14             prevout = COutPoint(int(txid, 16), 0)
    15
    16         # Whether the double-spend is allowed is evaluated by including all
    17-        # child fees - 40 BTC - so this attempt is rejected.
    18+        # child fees - 20 BTC - so this attempt is rejected.
    19         dbl_tx = CTransaction()
    20         dbl_tx.vin = [CTxIn(tx0_outpoint, nSequence=0)]
    21-        dbl_tx.vout = [CTxOut(initial_nValue - 30*COIN, CScript([1]))]
    22+        dbl_tx.vout = [CTxOut(initial_nValue - 20*COIN, CScript([1]))]
    23         dbl_tx_hex = txToHex(dbl_tx)
    24
    25         try:
    

    But then it fails in Running test doublespend tree... with

    0Running test simple doublespend...
    1Running test doublespend chain...
    2Running test doublespend tree...
    3JSONRPC error: 64: too-long-mempool-chain
    

    @sdaftuar @petertodd ping

  3. laanwj added the label Tests on Dec 1, 2015
  4. laanwj closed this on Dec 1, 2015

  5. MarcoFalke locked this on Sep 8, 2021


sipa paveljanik

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me