rpc: remove cs_main lock from `createrawtransaction` #7156

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_12_createrawtransaction_nolock changing 1 files +0 −1

laanwj commented at 12:54 PM on December 2, 2015: member

Continues work to remove/push down RPC locks from #7013. createrawtransaction is a pure utility function that doesn't use main's data structures, so it does not require that lock.

Despite being a one-line change, needs to be reviewed carefully. Although I didn't find any, there may be unguarded use of main data structures deeper in the call chain. Not meant for 0.12

rpc: remove cs_main lock from `createrawtransaction`

This is a pure utility function that doesn't use
main's data structures, so it does not require that lock.

6e76587360

laanwj added the label RPC on Dec 2, 2015
jonasschnelli commented at 1:08 PM on December 2, 2015: contributor

Code Review utACK. Can't find any unguarded deeper structure either.
jgarzik commented at 2:52 PM on December 2, 2015: contributor

ACK
jtimon commented at 1:08 AM on December 4, 2015: contributor

createrawtransaction() doesn't use any non-local variable and its parameters const UniValue& params, bool fHelp are both cs_main-safe. I don't need to test this. ACK
dcousens commented at 1:21 AM on December 4, 2015: contributor

utACK

I couldn't find any unguarded paths.
paveljanik commented at 9:51 AM on December 5, 2015: contributor

ACK
instagibbs commented at 2:54 PM on December 8, 2015: member

utACK
laanwj merged this on Dec 11, 2015
laanwj closed this on Dec 11, 2015
laanwj referenced this in commit 9ee02cf564 on Dec 11, 2015
luke-jr referenced this in commit d658fe200e on Dec 28, 2015
luke-jr referenced this in commit 73e32e3dbf on Dec 28, 2015
luke-jr referenced this in commit a132aceaf2 on Jan 13, 2016
luke-jr referenced this in commit d4952b8b6e on Jun 9, 2016
luke-jr referenced this in commit d527ff195c on Jun 26, 2016
codablock referenced this in commit fa749ee81f on Sep 16, 2017
codablock referenced this in commit 14afd7168e on Sep 19, 2017
codablock referenced this in commit 2ee1b2fcd4 on Dec 9, 2017
codablock referenced this in commit 3f6d6572f9 on Dec 9, 2017
LarryRuane referenced this in commit a87c3a8f9f on Feb 18, 2021
LarryRuane referenced this in commit 274c2f0384 on Feb 19, 2021
LarryRuane referenced this in commit 2713f9680d on Feb 19, 2021
zkbot referenced this in commit b08c673ddd on Feb 19, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7013 Remove LOCK(cs_main) from decodescript