[qt] Use tr() instead of _() #7158

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-translations changing 2 files +43 −8

MarcoFalke commented at 3:00 PM on December 2, 2015: member

code move between bitcoind an bitcoin-qt is not move only. I did it wrong in fa41d4c8c6e3f84a9117c0addf51a87f14321e2a.
laanwj commented at 3:05 PM on December 2, 2015: member

Please do a 'make translate' in src and commit the bitcoin_en.ts (not going to do another global translations update before the 0.12 branch, so that will have to do)
laanwj added the label GUI on Dec 2, 2015
jonasschnelli commented at 3:08 PM on December 2, 2015: contributor

Thanks! utACK.
MarcoFalke force-pushed on Dec 2, 2015
[qt] Use tr() instead of _()
Also, `make translate`
fab83476ac
MarcoFalke force-pushed on Dec 2, 2015
MarcoFalke commented at 4:27 PM on December 2, 2015: member

Force pushed because HelpMessageOpt() only accepts toStdString()
laanwj commented at 4:48 PM on December 2, 2015: member

utACK
jonasschnelli commented at 7:00 PM on December 2, 2015: contributor

Gave it a testshot with -lang=fr_FR. It does not translate. Do we need new strings/translations? The translation is available in bitcoin_fr.ts.

See: <img width="1439" alt="bildschirmfoto 2015-12-02 um 19 58 22" src="https://cloud.githubusercontent.com/assets/178464/11540818/372a5f76-992f-11e5-9b62-55af4542c9c7.png">
MarcoFalke commented at 7:40 PM on December 2, 2015: member

Gave it a testshot with -lang=fr_FR. @jonasschnelli Thanks for having a look!

It does not translate. Do we need new strings/translations?

Yes, resetguisettings, choosedatadir and splash need fresh translations anyway.

uioptions, lang, min, rootcertificates are possibly gone from transifex due to the mistake.

I think @laanwj isn't doing a sync for rc1 but for rc2

The translation is available in bitcoin_fr.ts.

They shouldn't imo. You are not running a clean build?
jonasschnelli commented at 7:08 AM on December 3, 2015: contributor
Tested again and something I don't understand. I took a (almost) fresh repository and added...
```
    <message>
        <source>Start minimized</source>
        <translation>(FR)Start minimized</translation>
    </message>
```
to bitcoin_fr.ts. Compiled again.
```
jonasschnelli$ pmake
  GEN      qt/locale/bitcoin_fr.qm
  GEN      qt/qrc_bitcoin_locale.cpp
  CXX      qt/qt_libbitcoinqt_a-qrc_bitcoin_locale.o
  AR       qt/libbitcoinqt.a
  OBJCXXLD qt/bitcoin-qt
  CXXLD    qt/test/test_bitcoin-qt
```
(^ --- looks good)

But it looks like that the changes has no effect: <img width="892" alt="bildschirmfoto 2015-12-03 um 08 06 47" src="https://cloud.githubusercontent.com/assets/178464/11554054/de1ddf5a-9994-11e5-9d76-aefed5a2b85e.png">

Changing a different already existing translations works: <img width="256" alt="bildschirmfoto 2015-12-03 um 08 06 36" src="https://cloud.githubusercontent.com/assets/178464/11554059/e6af1058-9994-11e5-882f-b3979c621048.png">

What am I doing wrong or why does it not translate the strings added to the french translation file?

laanwj commented at 9:49 AM on December 3, 2015: member

Tested ACK. I applied this patch, then added the following in the context HelpMessageDialog in bitcoin_fr.ts

<context>
    <name>HelpMessageDialog</name>
...
    <message>
        <source>Start minimized</source>
        <translation>French translation</translation>
    </message>
</context>

Then build and show options:

$ make -j10
$ src/qt/bitcoin-qt -lang=fr --help
...
UI Options:
  -min
       French translation
...

laanwj merged this on Dec 3, 2015
laanwj closed this on Dec 3, 2015
laanwj referenced this in commit 3cd836c1d8 on Dec 3, 2015
jonasschnelli commented at 9:53 AM on December 3, 2015: contributor

Thanks! I mixed up the <context>.
MarcoFalke deleted the branch on Dec 3, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels