tests: remove necessity to call create_callback_map #7171

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_12_p2p_test_no_cbmap changing 7 files +2 −32

laanwj commented at 12:26 PM on December 4, 2015: member
Remove necessity to call create_callback_map (as well as the function itself) from the Python P2P test framework. Invoke the appropriate methods directly.
- Easy to forget to call it and wonder why it doesn't work
- Simplifies the code
- This makes it easier to handle new messages in subclasses

test: remove necessity to call create_callback_map

Remove necessity to call create_callback_map (as well as the function
itself) from the Python P2P test framework. Invoke the appropriate
methods directly.

- Easy to forget to call it and wonder why it doesn't work
- Simplifies the code
- This makes it easier to handle new messages in subclasses

2f601d215d

laanwj added the label Tests on Dec 4, 2015
laanwj renamed this:
~~test: remove necessity to call create_callback_map~~
tests: remove necessity to call create_callback_map
on Dec 4, 2015
laanwj added the label Needs backport on Dec 4, 2015
MarcoFalke commented at 1:47 PM on December 4, 2015: member

utACK 2f601d2
sdaftuar commented at 8:54 PM on December 4, 2015: member

utACK
laanwj merged this on Dec 7, 2015
laanwj closed this on Dec 7, 2015
laanwj referenced this in commit 82bcf405f6 on Dec 7, 2015
laanwj referenced this in commit b2d7ada372 on Dec 7, 2015
laanwj commented at 8:09 AM on February 4, 2016: member

Was backported to 0.12 via b2d7ada3727f026ccd83d3d64c75aab660d8053e
laanwj removed the label Needs backport on Feb 4, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels