Debug window, Peers: appears connected when its not #7195

issue raedah opened this issue on December 9, 2015

raedah commented at 7:56 PM on December 9, 2015: none
1. Connect two bitcoin-qt v0.11.2 instances together on a local network.
2. Turn off the router.
3. See debug window, peers, shows peer still in the list, with a very low ping time. View details and see that the Last Receive time is counting upward.
4. Plug back in the router, peers disappear from list as soon as network connectivity is reestablished.
Peers appearing connected with a low ping time, even though nothing is being received, is misleading to the user. This was tested on linux.
jonasschnelli added the label GUI on Dec 10, 2015
laanwj commented at 11:09 AM on December 10, 2015: member

A) Due to how TCP works, it is impossible to instantly detect the router disconnecting. It will just assume a temporary delay. It will instantly detect (and remove the entry) when connectivity is reestablished when receives a RST as the other side (or router in case of NAT) doesn't know of the open connection. B) Ping time can only be updated if a ping is in progress.

Though it could be improved somewhat: right now I think the ping time is only updated if the pong message is received, it could instead report the status of the last ping in progress (and like LastReceive count up if there is no answer).
laanwj added the label Priority Low on Dec 10, 2015
laanwj added the label P2P on Dec 10, 2015
raedah commented at 10:01 PM on December 10, 2015: none

it could instead report the status of the last ping in progress (and like LastReceive count up if there is no answer).

I agree, that would do the trick.
laanwj removed the label Priority Low on Dec 6, 2017
MarcoFalke commented at 8:58 PM on April 26, 2020: member

If you select the node, it will show the last send/receive
MarcoFalke closed this on Apr 26, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels