qt5: Use the fixed font the system recommends #7214

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-qt5monospace changing 1 files +8 −0

MarcoFalke commented at 9:12 PM on December 14, 2015: member

Guess it can't hurt to use the system recommendation in fixedPitchFont(). This may even provide a workaround for #7017.

http://doc.qt.io/qt-5/qfontdatabase.html#systemFont was introduced in Qt 5.2.
qt5: Use the fixed font the system recommends fa2f4bc4eb
MarcoFalke commented at 9:22 PM on December 14, 2015: member

@jonasschnelli Mind to create binaries?
jonasschnelli added the label GUI on Dec 15, 2015
MarcoFalke commented at 9:17 AM on December 15, 2015: member

Great, will try this soon: https://bitcoin.jonasschnelli.ch/pulls/7214/

... Looks like this does not change anything.
MarcoFalke commented at 10:51 AM on December 15, 2015: member

@luke-jr @ptschip Is this helpful? Can you change the font via the system?
luke-jr commented at 12:30 PM on December 15, 2015: member

@MarcoFalke I don't have a problem with the current code, and I don't use Qt5...
laanwj commented at 10:01 AM on December 17, 2015: member

Concept ACK, although I'd expect <pre> already does this
luke-jr commented at 11:08 AM on December 17, 2015: member

@laanwj Good point... <pre> would likely be Qt4-compatible too. Has anyone tried this?
MarcoFalke commented at 12:02 PM on December 17, 2015: member

I think I already tried < pre > in #6864
MarcoFalke commented at 12:04 PM on December 17, 2015: member

Concept ACK

It looks like this does not fix any bug or change the behavior. We could as well just close this PR, but I don't have a strong opinion here.
jonasschnelli commented at 1:10 PM on December 22, 2015: contributor

Looks much better on OSX now:

Current Master <img width="940" alt="bildschirmfoto 2015-12-22 um 14 09 50" src="https://cloud.githubusercontent.com/assets/178464/11955853/b35b9354-a8b5-11e5-8e09-52db8255b6d2.png">

This PR: <img width="940" alt="bildschirmfoto 2015-12-22 um 14 09 06" src="https://cloud.githubusercontent.com/assets/178464/11955856/b8760694-a8b5-11e5-93c5-ad55aa58e62c.png">

Will test on Linux/Windows soon.
MarcoFalke commented at 1:12 PM on December 22, 2015: member

Will test on Linux/Windows soon.

I think I did this and could not find a difference.
jonasschnelli commented at 1:16 PM on December 22, 2015: contributor

Tested ACK fa2f4bc4eb0f21f5be8c88954ae2d99c5b18b987 nit (not related to this PR): the font "feels" smaller on windows? Any reason why?

<img width="918" alt="bildschirmfoto 2015-12-22 um 14 12 08" src="https://cloud.githubusercontent.com/assets/178464/11955932/6900d084-a8b6-11e5-80c1-8b4954378719.png"> <img width="1186" alt="bildschirmfoto 2015-12-22 um 14 13 31" src="https://cloud.githubusercontent.com/assets/178464/11955933/692c8bca-a8b6-11e5-9d53-673e3f2b40c9.png">
jonasschnelli merged this on Dec 23, 2015
jonasschnelli closed this on Dec 23, 2015
jonasschnelli referenced this in commit be9a9a3d22 on Dec 23, 2015
MarcoFalke deleted the branch on Dec 23, 2015
luke-jr referenced this in commit c0cb78630e on Jan 10, 2016
luke-jr referenced this in commit a1af9051fd on Jan 10, 2016
luke-jr referenced this in commit a71fffd0ac on Jan 13, 2016
luke-jr referenced this in commit 6f8346db5f on Jan 13, 2016
fanquake deleted a comment on Mar 10, 2020
fanquake deleted a comment on Mar 10, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#7017 Showing very tiny font in the Debug console tab