Tests: Add more tests to p2p-fullblocktest #7226

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:add-more-tests changing 2 files +146 −12

sdaftuar commented at 8:04 PM on December 17, 2015: member

@laanwj This is part of a longer-run effort towards being able to deprecate the java comparison tool, without losing test coverage.

I've ported a handful more tests from the java test to p2p-fullblocktest.py. I intend to continue to port more tests over (unless someone can please beat me to it!) but it'll be at least a few weeks before I return to working on this, so I thought I'd share what I have now.

in qa/rpc-tests/p2p-fullblocktest.py:None in 83ce22e37e outdated

  14 | @@ -15,7 +15,9 @@
  15 |  import time
  16 |  import numbers
  17 |  from test_framework.key import CECKey
  18 | -from test_framework.script import CScript, CScriptOp, SignatureHash, SIGHASH_ALL, OP_TRUE
  19 | +from test_framework.script import CScript, CScriptOp, SignatureHash, SIGHASH_ALL, OP_TRUE, OP_FALSE
  20 | +
  21 | +MAX_BLOCK_SIZE = 1000000

MarcoFalke commented at 8:36 AM on December 18, 2015:

What about moving this to the framework instead?

sdaftuar force-pushed on Dec 18, 2015
Add more tests to p2p-fullblocktest 9b41a5fba2
sdaftuar commented at 10:40 AM on December 18, 2015: member

@MarcoFalke Moved the global to mininode.py. Also fixed a bug in the next-to-last test that was causing travis to fail (there's a separate PR to fix the issue noted in the TODO, see #7225).
jonasschnelli added the label Tests on Dec 19, 2015
laanwj commented at 8:51 AM on December 22, 2015: member

ACK
laanwj merged this on Dec 22, 2015
laanwj closed this on Dec 22, 2015
laanwj referenced this in commit ed095f0407 on Dec 22, 2015
laanwj referenced this in commit 301f16ad1c on Dec 22, 2015
luke-jr referenced this in commit 077e931575 on Jan 10, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels