salvagewallet fails assertion. Aborted (core dumped) #7231

issue MarcoFalke opened this issue on December 18, 2015

MarcoFalke commented at 4:35 PM on December 18, 2015: member

Steps to reproduce:

$ ./configure CPPFLAGS=-DDEBUG_LOCKORDER
$ make
$ src/bitcoind -regtest -salvagewallet
Assertion failed: lock cs_wallet not held in wallet/wallet.cpp:153; locks held:
Aborted (core dumped)

jonasschnelli commented at 10:19 AM on December 19, 2015: contributor

-salvagewallet calls the CWallet::Verify() method which does not lock cs_wallet, but, some subfunctions call AssertLockHeld(). Because CWallet::Verify() can only happen over init.cpp/main thread, I guess this is tolerable.

The assert only "fires" when CPPFLAGS=-DDEBUG_LOCKORDER is enabled.

A "fix" (only a debug mode fix) would probably be a LOCK(cs_wallet) at the beginning of CWallet::Verify().
MarcoFalke commented at 1:50 PM on December 19, 2015: member

@jonasschnelli Thanks! Looks like fa33d9740c9b0d1071094ab6c1736f27a7090c95 (#7229) fixes it.
MarcoFalke closed this on Jan 7, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

MarcoFalke

jonasschnelli