Fix issue #659, and cleanup wallet/command-line argument handling a bit #726

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:issue659 changing 5 files +86 −45
  1. gavinandresen commented at 7:13 PM on December 23, 2011: contributor

    This moves all of the "if running over Tor" logic to one place (in init.cpp).

    It also fixes issues where settings made in the GUI (like fUseProxy) and stored in the wallet could not be over-ridden in the bitcoin.conf file or command-line, by moving command-line-flag-setting code to after the wallet has been loaded.

    That also meant moving the "bind to listen port" to after the wallet was loaded, but that should be OK 99.99% of the time because the lock file is still checked early to protect against accidentally running bitcoin twice.

  2. gavinandresen commented at 8:07 PM on December 23, 2011: contributor

    Forgot to say how I tested:

    Ran bitcoind normally to get caught up on the block chain, verify that I get more than 8 connections, and verify (by looking at debug.log) that I connect to the dns seeds and IRC.

    Ran Vidalia on my Mac, got connected to the Tor network. Ran bitcoind -proxy=127.0.0.1:2050 VERIFY: I get only 8 connections, and do not connect to dns seeds or IRC.

    Then removed addr.dat, and re-ran with -proxy... VERIFY: built-in IP seeding eventually (after trying several non-listening seeds) bootstraps through Tor.

  3. Fix issue #659, and cleanup wallet/command-line argument handling a bit 0fcf91ea1e
  4. gavinandresen merged this on Jan 3, 2012
  5. gavinandresen closed this on Jan 3, 2012

  6. destenson referenced this in commit 1b41f851bf on Jun 26, 2016
  7. ptschip referenced this in commit db05363308 on Aug 6, 2017
  8. kallewoof referenced this in commit 64f8be13cf on Oct 4, 2019
  9. DrahtBot locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me