Wallet creattransaction is not clean code, should be revised #7260

issue sidhujag opened this issue on December 28, 2015
  1. sidhujag commented at 7:25 AM on December 28, 2015: none

    Specifically the fee part and the fact that you wait until the end to check enough fees or continue. Needs revision.. Seems like it was added on over time and resulted in code thats not clean to a new developer

  2. jonasschnelli commented at 8:23 AM on December 28, 2015: contributor

    Can you be more specific?

    Do you think the way of how core's wallet calculate the fee (endless iteration until we have enough fee) is suboptimal? What would be your approach?

    Keep in mind that increasing the fee might require an additional input which enlarges the transaction (which requires more fee).

  3. jonasschnelli added the label Wallet on Dec 28, 2015
  4. laanwj commented at 11:13 AM on January 5, 2016: member

    You're always welcome to improve this. But this is too aspecitic to be an open issue, so closing.

  5. laanwj closed this on Jan 5, 2016

  6. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me